Skip to content

Conversation

@Donapi
Copy link
Contributor

@Donapi Donapi commented Aug 21, 2023

@robodoo
Copy link
Collaborator

robodoo commented Aug 21, 2023

@xpl-odoo xpl-odoo marked this pull request as draft August 21, 2023 14:25
@xpl-odoo xpl-odoo changed the base branch from 16.0 to saas-16.3 August 21, 2023 14:25
@xpl-odoo xpl-odoo changed the base branch from saas-16.3 to 16.0 August 21, 2023 14:26
@xpl-odoo xpl-odoo force-pushed the 16.0.sign-update-doc-dopi branch from 831317a to 4ba75ac Compare August 21, 2023 14:29
@xpl-odoo xpl-odoo marked this pull request as ready for review August 21, 2023 14:30
@C3POdoo C3POdoo requested a review from a team August 21, 2023 14:30
@Donapi Donapi requested a review from zulu-odoo August 24, 2023 07:04
Copy link
Contributor

@zulu-odoo zulu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dona,

As discussed, feel free to modify the doc after our comments :)

Thanks

@Donapi Donapi force-pushed the 16.0.sign-update-doc-dopi branch from 4ba75ac to 8eaed00 Compare August 28, 2023 08:55
@Donapi Donapi requested review from a team and xpl-odoo and removed request for xpl-odoo August 28, 2023 08:56
@Donapi Donapi force-pushed the 16.0.sign-update-doc-dopi branch from 8eaed00 to 2ad43c4 Compare August 28, 2023 10:05
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A live review of the whole page could be useful. It would be nice to explain roles better and maybe review the structure.

@Donapi Donapi force-pushed the 16.0.sign-update-doc-dopi branch from 2ad43c4 to 22c2456 Compare September 18, 2023 13:18
@Donapi Donapi requested a review from xpl-odoo September 18, 2023 13:32
@Donapi Donapi force-pushed the 16.0.sign-update-doc-dopi branch from 22c2456 to 66a591f Compare November 24, 2023 09:39
Signatory hash
==============

Each time someone signs a document, a hash - a unique ID number - is generated to ensure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each time someone signs a document, a hash - a unique ID number - is generated to ensure
Each time someone signs a document, a hash - a unique digital signature of the operation - is generated to ensure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to make it somewhat clear that the content the person used for signing (their name, their signature, the input fields they filled in) is used to compute this signature - so any alteration will corrupt the whole 'hash chain' and be visible to the system

here's how chatgpt puts it, which is not a bad start:

In Odoo Sign, the integrity and inalterability of documents are safeguarded using a hashing technique. At each stage of the signing process, a unique hash is created based on the document's current content and the cumulative hashes of previous steps. This includes any information added by users, like names and signatures. This method ensures that any changes made after a signature is affixed can be easily detected, maintaining the document's authenticity and security throughout its lifecycle."

@Donapi Donapi force-pushed the 16.0.sign-update-doc-dopi branch 2 times, most recently from fbeb7e3 to 6790b25 Compare November 24, 2023 11:46
@xpl-odoo xpl-odoo force-pushed the 16.0.sign-update-doc-dopi branch from 6790b25 to d1ecfa8 Compare November 24, 2023 12:58
@xpl-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 24, 2023
task-3433578

closes #5558

Signed-off-by: Xavier Platteau (xpl) <[email protected]>
@robodoo robodoo closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants