[ADD] MRP: Add Scrap during manufacturing #4954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ksc-odoo
reviewed
Jun 29, 2023
Contributor
ksc-odoo
left a comment
ksc-odoo
left a comment
There was a problem hiding this comment.
@hojo-odoo just finished peer reviewing this doc - great work 👍 only a few minor adjustments that need to be addressed - other than that, awesome job!!!
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
14.0-mrp-add-scrap-manufacturing-hojo
branch
from
935e4d3 to
085efea
Compare
samueljlieber
requested changes
Jul 10, 2023
Contributor
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @hojo-odoo! Nice job adding this new doc! Your RST is looking pretty great :) I have only a few technical changes and suggestions, please see below. Please tag me again for a final look once this PR is ready, thank you!!
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
...ications/inventory_and_mrp/inventory/management/warehouses/difference_warehouse_location.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
14.0-mrp-add-scrap-manufacturing-hojo
branch
from
085efea to
9083ff3
Compare
Contributor
Author
|
Hey @samueljlieber, This is ready for another look. Thanks, |
samueljlieber
approved these changes
Jul 20, 2023
Contributor
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
HI @hojo-odoo I am approving now with one very small fix. Please implement this and then we are all set to pass this over 🙂 Nice job!
| :align: center | ||
| :alt: The tablet view icon for a work order. | ||
|
|
||
| With tablet view open, click the :guilabel:`☰` (menu) button at the top left of the screen, then |
Contributor
There was a problem hiding this comment.
Small icon formatting fix 🙂
Suggested change
| With tablet view open, click the :guilabel:`☰` (menu) button at the top left of the screen, then | |
| With tablet view open, click the :guilabel:`☰ (menu)` button at the top left of the screen, then |
hojo-odoo
force-pushed
the
14.0-mrp-add-scrap-manufacturing-hojo
branch
from
9083ff3 to
0cea1ab
Compare
StraubCreative
approved these changes
Aug 2, 2023
Contributor
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
Hi @hojo-odoo
Another great doc :)
I have some suggestions for you, below, to consider.
Might also want to take a look at a couple of the examples
- Product A, Z, Y...think it's better to use actual product examples instead of generic placeholders.
- it's not clear at times whether we're reading an instruction or a math formula. Would clearly differentiate the two if you can.
Can merge when you're ready!
@robodoo delegate=hojo-odoo
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/manufacturing/management/scrap_manufacturing.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
14.0-mrp-add-scrap-manufacturing-hojo
branch
from
0cea1ab to
3108ea1
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Aug 3, 2023
closes #4954 Signed-off-by: John Holton (hojo) <[email protected]>
Collaborator
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
Collaborator
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced Aug 8, 2023
This was referenced Aug 8, 2023
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new doc detailing how to scrap components and finished products during the manufacturing process.