[IMP] website: "pages" page #4871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
toaa-odoo
force-pushed
the
16.0-pages-toaa
branch
3 times, most recently
from
b98f42f to
5e12a68
Compare
auva-odoo
force-pushed
the
16.0-pages-toaa
branch
5 times, most recently
from
5063c77 to
ce49002
Compare
LoredanaLrpz
requested changes
Jul 28, 2023
Contributor
LoredanaLrpz
left a comment
LoredanaLrpz
left a comment
There was a problem hiding this comment.
Hey, @auva-odoo , great work overall =D
Here's my review
Please note that I usually don't check the count of characters when I make suggestions x)
Also, don't forget to change the commit msg since you co-authored the PR
--> commit --amend and write
Co-authored-by: Toaa <[email protected]>
Co-authored-by: Auva <[email protected]>
auva-odoo
force-pushed
the
16.0-pages-toaa
branch
from
ce49002 to
d906b40
Compare
auva-odoo
force-pushed
the
16.0-pages-toaa
branch
from
d906b40 to
03e6270
Compare
xpl-odoo
requested changes
Aug 3, 2023
Contributor
xpl-odoo
left a comment
xpl-odoo
left a comment
There was a problem hiding this comment.
Nice job Audrey/Tom! :) Don't hesitate to ask questions regarding my suggestions or challenge them ;)
Adding a documentation on "pages" within the already existing "page" toctree task-3383323 Co-authored-by: Toaa <[email protected]> Co-authored-by: Auva <[email protected]>
auva-odoo
force-pushed
the
16.0-pages-toaa
branch
from
03e6270 to
ccb2564
Compare
xpl-odoo
approved these changes
Aug 7, 2023
Contributor
|
@robodoo r+ |
Collaborator
|
I'm sorry, @auva-odoo. I'm afraid I can't do that. |
Contributor
|
@robodoo r+ |
This was referenced Aug 7, 2023
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a documentation on "pages" within the already existing "page" toctree
task-3383323
@auva-odoo Hi Audrey, could you have a - thorough - look at this PR? I wrote it based on your notes, but I could not understand everything. You'd know better what is supposed to be in here :)