[IMP] odoo_theme: toctrees-l1,l2 design improvement #4674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mano-odoo
force-pushed
the
14-toctree-fallback-l1-l2-mano
branch
2 times, most recently
from
24bf9e3 to
ab9efb4
Compare
mano-odoo
changed the title
mano-odoo
force-pushed
the
14-toctree-fallback-l1-l2-mano
branch
from
ab9efb4 to
de60c37
Compare
edi-odoo
approved these changes
Jun 28, 2023
Contributor
edi-odoo
left a comment
edi-odoo
left a comment
There was a problem hiding this comment.
LGTM! @AntoineVDV could you check the JS please ?
Issue 1: ======== The toctrees in the documentation are visually inconsistent because of the content. Sometimes we have titles that are also links and visually collides with the rest of the toc making it hard to read. This applies to toctree-l1 and toctree-l2. Fix 1: ======== When we have a link and title toctree-l2 in a list containing other nested toc, we apply another styling displaying it with the same color as a title, but with an icon and hover behavior indicating that it is a link. (This commit also changes the direction of the i-link icon to make it standard). Issue 2: ======== When we have only have toctree-l1 links without nested toc the toctree is uselessly taking a lot of space. Fix: 2 ======== In these scenario we add a class to the toctree wrapper to replace the toctree-l1 style with a toctree-l2. task-3138525 task-3138563 part of task-3059178
AntoineVDV
force-pushed
the
14-toctree-fallback-l1-l2-mano
branch
from
de60c37 to
6da7828
Compare
AntoineVDV
approved these changes
Nov 17, 2023
Collaborator
AntoineVDV
left a comment
AntoineVDV
left a comment
There was a problem hiding this comment.
Hello, sorry for the delay! I had to put this aside while there was urgent stuff to deal with. When I had a quick look some time ago I spotted visual glitches, but after a rebase it seems to be fixed, so all good for me :)
@robodoo r+
robodoo
pushed a commit
that referenced
this pull request
Nov 17, 2023
Issue 1: ======== The toctrees in the documentation are visually inconsistent because of the content. Sometimes we have titles that are also links and visually collides with the rest of the toc making it hard to read. This applies to toctree-l1 and toctree-l2. Fix 1: ======== When we have a link and title toctree-l2 in a list containing other nested toc, we apply another styling displaying it with the same color as a title, but with an icon and hover behavior indicating that it is a link. (This commit also changes the direction of the i-link icon to make it standard). Issue 2: ======== When we have only have toctree-l1 links without nested toc the toctree is uselessly taking a lot of space. Fix: 2 ======== In these scenario we add a class to the toctree wrapper to replace the toctree-l1 style with a toctree-l2. task-3138525 task-3138563 part of task-3059178 closes #4674 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
Collaborator
|
@mano-odoo @AntoineVDV staging failed: ci/runbot on 7b206bdc5cb3268957926341ef3c095b574acf68 (view more at https://runbot.odoo.com/runbot/build/53851693) |
Collaborator
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
Nov 17, 2023
Issue 1: ======== The toctrees in the documentation are visually inconsistent because of the content. Sometimes we have titles that are also links and visually collides with the rest of the toc making it hard to read. This applies to toctree-l1 and toctree-l2. Fix 1: ======== When we have a link and title toctree-l2 in a list containing other nested toc, we apply another styling displaying it with the same color as a title, but with an icon and hover behavior indicating that it is a link. (This commit also changes the direction of the i-link icon to make it standard). Issue 2: ======== When we have only have toctree-l1 links without nested toc the toctree is uselessly taking a lot of space. Fix: 2 ======== In these scenario we add a class to the toctree wrapper to replace the toctree-l1 style with a toctree-l2. task-3138525 task-3138563 part of task-3059178 closes #4674 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
This was referenced Nov 17, 2023
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1:
The toctrees in the documentation are visually inconsistent because of
the content. Sometimes we have titles that are also links and visually
collide with the rest of the toc making it hard to read. This applies
to toctree-l1 and toctree-l2.
Fix 1:
When we have a link and title toctree-l1 or toctree-l2 in a list
containing other nested toc, we apply another styling displaying it
with the same color as a title, but with an icon and hover behavior
indicating that it is a link. (This commit also changes the direction of
the i-link icon to make it standard).
Issue 2:
When we only have toctree-l1 links without nested toc the toctree
is uselessly taking up a lot of space.
Fix: 2
In this scenario we replace the toctree-l1 class with toctree-l2 to
make them appear as a discreet list.
task-3138525
task-3138563
part of
task-3059178