Skip to content

Conversation

@larm-odoo
Copy link
Contributor

Updated this doc for specific v 16 changes - no edit button or save button, and to make something it's a 'new' button not 'create'

@larm-odoo larm-odoo requested a review from a team May 9, 2023 16:43
@robodoo
Copy link
Collaborator

robodoo commented May 9, 2023

@C3POdoo C3POdoo requested a review from a team May 9, 2023 16:44
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larm-odoo just finished my review on this doc - awesome job! Remember to ensure that all headings don't start with an action/verb (per JCS' recent comments) - and refrain from using "+" or "&" in headings, either (per ZST's request). If you have any questions or need clarification on anything, don't hesitate to reach out. Feel free to re-tag me once these changes have been made, so we can make sure everything is good-to-go before moving to Tech Review. Thanks!

@larm-odoo larm-odoo force-pushed the 16.0-inventory-make-targeted-edits-larm branch from cddd67a to 12fd044 Compare May 10, 2023 15:43
@larm-odoo larm-odoo requested a review from ksc-odoo May 10, 2023 15:44
@larm-odoo
Copy link
Contributor Author

Ready for another peek, @ksc-odoo - and thank you!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@larm-odoo
Copy link
Contributor Author

Thanks again @ksc-odoo! Looks like @StraubCreative is up next

@larm-odoo larm-odoo requested a review from StraubCreative May 11, 2023 19:12
@StraubCreative StraubCreative requested review from samueljlieber and removed request for StraubCreative May 19, 2023 01:03
@StraubCreative
Copy link
Contributor

@samueljlieber same here— can you take a look first? Ty!

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo just a couple small technical changes, please see below and then tag me once more after the changes have been made :)

@larm-odoo larm-odoo force-pushed the 16.0-inventory-make-targeted-edits-larm branch from 12fd044 to 52d2d3a Compare May 19, 2023 16:15
@larm-odoo larm-odoo requested a review from samueljlieber May 19, 2023 16:15
@larm-odoo
Copy link
Contributor Author

hi @samueljlieber - these are all set for you to look at again!

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @larm-odoo these changes in this PR look good to me, nice job! Passing to @StraubCreative for final review 🙂

@Felicious Felicious removed the request for review from a team August 16, 2023 23:44
@samueljlieber samueljlieber force-pushed the 16.0-inventory-make-targeted-edits-larm branch from 52d2d3a to 25b2c8e Compare December 26, 2023 18:13
@samueljlieber
Copy link
Contributor

Rebased to latest in 25b2c8e since this PR has not been rebased after the 16.0 Inventory restructure.

@larm-odoo and @Felicious is this PR still relevant?

@larm-odoo
Copy link
Contributor Author

Rebased to latest in 25b2c8e since this PR has not been rebased after the 16.0 Inventory restructure.

@larm-odoo and @Felicious is this PR still relevant?

Yes- I checked the current v16 doc, and it could use this update still. Even with the restructuring of the inventory docs, this information is updated for 16 and is good to go!

@samueljlieber samueljlieber requested a review from a team December 26, 2023 19:13
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small correction

@samueljlieber samueljlieber force-pushed the 16.0-inventory-make-targeted-edits-larm branch from 25b2c8e to 4c61700 Compare December 26, 2023 19:26
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StraubCreative this PR is good to go 👍

@StraubCreative
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Dec 26, 2023
closes #4381

Signed-off-by: Zachary Straub (zst) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants