[IMP] Inventory: updated text for 16 and fixed rst errors #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
larm-odoo
requested review from
samueljlieber
and removed request for
samueljlieber
Contributor
Author
|
@odoo/inventory-doc-review this is also ready for a look when you have a moment- thank you! |
Felicious
reviewed
Jul 24, 2023
.../inventory_and_mrp/inventory/management/shipments_deliveries/receipts_delivery_two_steps.rst
Outdated
Show resolved
Hide resolved
larm-odoo
force-pushed
the
16.0-inventory-updating-text-for-16-larm
branch
from
69293be to
387a8d4
Compare
Contributor
Author
|
Thanks for the review, @Felicious! Per our discussion, I am tagging @meng-odoo for the final review since Zac is out, and this is such a small version change (only changed images and a few words). |
meng-odoo
suggested changes
Jul 26, 2023
Contributor
meng-odoo
left a comment
meng-odoo
left a comment
There was a problem hiding this comment.
Hi @larm-odoo, this looks good to me! I had a couple tiny changes that you can easily commit using the new method hehe :) Please go ahead and tag Sam for technical review afterwards!
.../inventory_and_mrp/inventory/management/shipments_deliveries/receipts_delivery_two_steps.rst
Outdated
Show resolved
Hide resolved
.../inventory_and_mrp/inventory/management/shipments_deliveries/receipts_delivery_two_steps.rst
Outdated
Show resolved
Hide resolved
larm-odoo
force-pushed
the
16.0-inventory-updating-text-for-16-larm
branch
from
387a8d4 to
e2f30aa
Compare
Contributor
Author
|
Hi @samueljlieber - per Meng, this is ready for ya! |
samueljlieber
approved these changes
Jul 27, 2023
Contributor
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Hi @larm-odoo the changes looks great to me, nice job!
@StraubCreative on to you!
StraubCreative
approved these changes
Aug 4, 2023
Contributor
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
LGTM 👍
@robodoo r+
This was referenced Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the 'create' button references to 'new' for 16, fixed a few extra ":"'s that appeared and messed up the RST code. Removed references to 'Edit' and 'Save' which are not needed in 16.