[FW][MERGE] odoo_theme: revamp header and menu for better mobile support #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the language names were translated to display "Français" instead of "French". This helped the user find their language in the switcher but it was taking too much horizontal space, and that space was not constant from one language to another. This commit removes the translations of the language names and simply goes with "FR", "NL", etc. which any user can identify as their language. task-2800937 X-original-commit: b1fa30f
task-2800937 X-original-commit: 411e1cb
task-2800937 X-original-commit: dee96ad
task-2800937 X-original-commit: 7284b11
task-2800937 X-original-commit: 9c53901
task-2800937 X-original-commit: 4ed8c22
task-2800937 X-original-commit: 3fd32fe
The mechanism that makes the version and language switchers test for valid URLs crashed when testing in localhost. The mechanism is now skipped if the URL starts with a '/'. X-original-commit: 98e98f6
Collaborator
Collaborator
Author
Collaborator
|
@fw-bot r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the switchers were hidden on mobile. These have been moved
to a sub-nav which also contains the button for the sidenav, leaving
more space for the searchbox so it can remain in the header. Like MDN
web docs, the navigation now slides in from the left instead of the
top.
See PR's commits for more details.
task-2800937
Forward-Port-Of: #2206