Skip to content

Conversation

@AntoineVDV
Copy link
Collaborator

@AntoineVDV AntoineVDV commented Jun 10, 2022

When the page gets too small for the "On this page" section (local tree
of content) to fit on the page, the section is now moved above the menu
(global tree of content) rather than being hidden.

task-2800970

@robodoo
Copy link
Collaborator

robodoo commented Jun 10, 2022

@AntoineVDV AntoineVDV force-pushed the 13.0-on-this-page-edi branch from 5315177 to 45306a2 Compare June 10, 2022 13:12
@edi-odoo edi-odoo force-pushed the 13.0-on-this-page-edi branch 2 times, most recently from 2143882 to c1bb4cb Compare June 10, 2022 14:11
@AntoineVDV AntoineVDV force-pushed the 13.0-on-this-page-edi branch from c1bb4cb to 3b8fb4d Compare June 13, 2022 11:56
@AntoineVDV AntoineVDV changed the title [WIP] on this page in side-nav (needs JS editing) [IMP] odoo_theme: show the "On this page" section in mobile Jun 13, 2022
@AntoineVDV AntoineVDV marked this pull request as ready for review June 13, 2022 11:57
@C3POdoo C3POdoo requested review from a team June 13, 2022 11:58
@AntoineVDV AntoineVDV removed the request for review from a team June 13, 2022 12:08
When the page gets too small for the "On this page" section (local tree
of content) to fit on the page, the section is now moved above the menu
(global tree of content) rather than being hidden.

task-2800970

Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
@AntoineVDV AntoineVDV force-pushed the 13.0-on-this-page-edi branch from 3b8fb4d to 58ea2f9 Compare June 13, 2022 12:22
Copy link
Collaborator Author

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

One issue remaining (to be fixed with task 2800937): On mobile and on pages with a large local TOC, the user needs to scroll the page to the top to be able to navigate the menu.

@AntoineVDV AntoineVDV removed the request for review from a team June 13, 2022 12:25
robodoo pushed a commit that referenced this pull request Jun 13, 2022
When the page gets too small for the "On this page" section (local tree
of content) to fit on the page, the section is now moved above the menu
(global tree of content) rather than being hidden.

task-2800970

closes #2179

Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
@robodoo robodoo closed this Jun 13, 2022
@robodoo robodoo temporarily deployed to merge June 13, 2022 13:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants