Fix a typo: user menu registry example #1975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brboi
requested changes
May 11, 2022
|
@brboi should I do anything else to merge my request? |
There is one last step required: a validation from @odoo/doc-review 😉 |
AntoineVDV
requested changes
May 16, 2022
There was a problem hiding this comment.
Hello @beshoynabeih, could you please squash your commits into one so we can proceed with the merge? :)
Ideally, the commit title would be something like [FIX] developer/frontend: typo in the user menu registry example.
|
@AntoineVDV I did the squash could you please check you |
@beshoynabeih As you can see here your pull request counts 5 commits. After squashing the commits into one, it should only have a single commit. |
|
@AntoineVDV thank you for helping. now it is one commit |
AntoineVDV
approved these changes
May 19, 2022
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix errors in javascript code example.