Skip to content

[ADD] accounting: new doc about outstanding account #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] accounting: new doc about outstanding account #1887

wants to merge 1 commit into from

Conversation

@Donapi
Copy link
Contributor

@Donapi Donapi commented Apr 28, 2022 •
edited
Loading

@robodoo
Copy link
Collaborator

robodoo commented Apr 28, 2022

Pull request status dashboard.

@C3POdoo C3POdoo requested review from a team April 28, 2022 13:14
@Donapi Donapi force-pushed the 14.0-outstandingaccounts-dopi branch from 48ca7f6 to 3d8ecb3 Compare April 28, 2022 13:25
@Donapi Donapi removed the request for review from a team April 28, 2022 13:25
@AntoineVDV AntoineVDV removed the request for review from a team April 28, 2022 14:33
AntoineVDV
AntoineVDV requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you put aside the nitpicking comments and the list formatting, this is quite good (technically speaking) for a first PR! 👍

xpl-odoo
xpl-odoo requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Dona! I see ANV reviewed at the same time so I tried to avoid any overlap :)

@Donapi Donapi changed the title [IMP] Outstanding Accounts: create documentation [ADD] accounting: new doc about outstanding account Apr 29, 2022
@Donapi Donapi marked this pull request as draft April 29, 2022 11:29
@Donapi Donapi changed the base branch from 14.0 to 15.0 April 29, 2022 11:29
@Donapi Donapi force-pushed the 14.0-outstandingaccounts-dopi branch from 3d8ecb3 to d2bf60d Compare April 29, 2022 11:31
@Donapi Donapi marked this pull request as ready for review April 29, 2022 11:32
@C3POdoo C3POdoo requested a review from a team April 29, 2022 11:32
@Donapi Donapi requested a review from xpl-odoo April 29, 2022 11:33
xpl-odoo
xpl-odoo approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

jcs-odoo
jcs-odoo requested changes May 13, 2022
View reviewed changes
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The council of JoJaTo reviewed this and was pleased.

However, please make a few changes (see all comments)

Have a wonderful birthday :D

@Donapi Donapi force-pushed the 14.0-outstandingaccounts-dopi branch from d2bf60d to 655a1f7 Compare May 16, 2022 08:22
jcs-odoo
jcs-odoo requested changes May 17, 2022
View reviewed changes
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Donapi !!

Just a couple small changes to do (really, close to nothing) and it will be good to go :)

content/applications/finance/accounting/bank/setup/outstanding_accounts.rst
From your :guilabel:`Accounting Dashboard`, click on the menu selection ⋮ of the journal you want to
configure, and click on :guilabel:`Configuration`, then open the :guilabel:`Incoming/Outgoing
Payments` tab. To display the outstanding accounts column, click on the toggle button and check the
:guilabel:`Outstanding Receipts/Payments accounts`, then update the account.
Copy link
Contributor

@jcs-odoo jcs-odoo May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and Save? not sure it's that important to mention but we usually do)

@Donapi Donapi force-pushed the 14.0-outstandingaccounts-dopi branch from 655a1f7 to 7d92d6f Compare May 17, 2022 08:58
@Donapi Donapi force-pushed the 14.0-outstandingaccounts-dopi branch from 7d92d6f to 69a7db4 Compare May 17, 2022 11:56
jcs-odoo
jcs-odoo approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@jcs-odoo jcs-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @Donapi :)
Looks good to me

@jcs-odoo jcs-odoo requested a review from a team May 17, 2022 11:58
AntoineVDV
AntoineVDV approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo r+

@robodoo robodoo closed this in 5de81c9 May 18, 2022
@robodoo robodoo temporarily deployed to merge May 18, 2022 10:36 Inactive
@fw-bot fw-bot mentioned this pull request May 18, 2022
Closed
This was referenced May 18, 2022
Closed
Closed
Closed
@fw-bot fw-bot deleted the 14.0-outstandingaccounts-dopi branch June 1, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AntoineVDV AntoineVDV AntoineVDV approved these changes

@jcs-odoo jcs-odoo jcs-odoo approved these changes

@xpl-odoo xpl-odoo xpl-odoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Donapi @robodoo @AntoineVDV @jcs-odoo @xpl-odoo