[IMP] amazon: explain how to use a carrier #1750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Demesmaeker
force-pushed
the
13.0-amazon_self_delivery_carrier-edm
branch
2 times, most recently
from
552804b to
61bf546
Compare
meng-odoo
suggested changes
Apr 21, 2022
Contributor
There was a problem hiding this comment.
@Demesmaeker Hello! Thanks for your contribution here. I'm just requesting a small wording change before we make the approval.
In case of an unsupported carrier or a self Delivery, Odoo won't block the user to use the Amazon connector, but explanation were needed for these cases. task-2804907
Demesmaeker
force-pushed
the
13.0-amazon_self_delivery_carrier-edm
branch
from
61bf546 to
6f509bd
Compare
Contributor
Author
|
@meng-odoo Hello! Thanks for your feedback, the change is done. =] |
meng-odoo
approved these changes
May 7, 2022
Contributor
meng-odoo
left a comment
meng-odoo
left a comment
There was a problem hiding this comment.
Hi @Demesmaeker! Thanks for making those changes. Everything looks great. I'll go ahead and push this to the next step in the review process.
robodoo
pushed a commit
that referenced
this pull request
May 9, 2022
In case of an unsupported carrier or a self Delivery, Odoo won't block the user to use the Amazon connector, but explanation were needed for these cases. task-2804907 closes #1750 Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an unsupported carrier or a self Delivery, Odoo won't block
the user to use the Amazon connector, but explanation were needed for
these cases.
task-2804907
see also: