[IMP] rental: Updated for request signature GUI changes #15067
Conversation
meval1006
commented
Oct 30, 2025
meval1006
commented
- Updated Rental page to remove outdated information
- Included the recent removal of the Sign Document button to the Action icon menu option of Request signature
- Major changes to the Customer Signature section
- Global document change of Can be rented to Rental
- Updated screenshots
- Updated icon style and naming
- Minor changes to the Reservations section
|
|
There was a problem hiding this comment.
Almost there, @meval1006! There was a lot of content to go through, so I appreciate that you resisted fixing the small style issues and stayed focused on updating the document for the signature workflow!
I just had a few clarification questions about the signature workflow itself and I can see that you've had a much better grasp on the style compared to your first PR! Great improvements in less than a week 😊
After those quick fixes, this PR is ready for another review!
|
|
||
| In the :guilabel:`Rental` section, there are options to configure :guilabel:`Default Delay Costs` | ||
| and :guilabel:`Default Padding Time`. There is also the option to activate :guilabel:`Rental | ||
| Transfers` and :guilabel:`Digital Documents`. |
There was a problem hiding this comment.
Out of curiosity, do you know what happened to this Digital Documents button? Did they remove all support of digital documents, or does it happen automatically somehow? It's probably not important, but asking in case it is, and making sure there isn't a strange roundabout way to digitize documents 🤔
| If creating a rental product outside of the *Rental* app, just ensure the :guilabel:`Can be | ||
| Rented` checkbox is ticked on the product form. By default, this checkbox is ticked whenever a | ||
| product is created directly in the *Rental* application. | ||
| If creating a rental product outside of the *Rental* app, just ensure the :guilabel:`Rental` |
There was a problem hiding this comment.
Adding this for your future PR of fixing style. Our updated style for this year includes
- Bold instead of italicizing app names
- For images, we've removed the
align: centerline
| .. note:: | ||
| If creating a rental product outside of the *Rental* app, just ensure the :guilabel:`Can be | ||
| Rented` checkbox is ticked on the product form. By default, this checkbox is ticked whenever a | ||
| product is created directly in the *Rental* application. | ||
| If creating a rental product outside of the *Rental* app, just ensure the :guilabel:`Rental` | ||
| checkbox is ticked on the product form. By default, this checkbox is ticked whenever a product is | ||
| created directly in the *Rental* application. |
There was a problem hiding this comment.
Actually, reading this note block again, is it even necessary? I think we've already detailed how to tick the Rental checkbox up in the lines above. I don't think users would get confused by this.
Personally, I believe we should just eliminate this entire note block
|
|
||
| To delete any rental pricing option, click the :guilabel:`🗑️ (trash)` icon, and that row is | ||
| deleted. | ||
| To delete any rental pricing option, click the :icon:`fa-trash-o` :guilabel:`(Delete icon)`, and that |
There was a problem hiding this comment.
no need to bold icon!
| To delete any rental pricing option, click the :icon:`fa-trash-o` :guilabel:`(Delete icon)`, and that | |
| To delete any rental pricing option, click the :icon:`fa-trash-o` :guilabel:`(Delete)` icon, and that |
| To delete any rental pricing option, click the :icon:`fa-trash-o` :guilabel:`(Delete icon)`, and that | ||
| row is deleted. |
There was a problem hiding this comment.
open to hearing your opinion on this, but I personally dont think we need to instruct readers that clicking the trash icon deletes a line. what do you think?
if you agree with me, let's just delete the line
| Documents` feature has been activated in the *Rental* application settings. To do so, navigate to | ||
| :menuselection:`Rental app --> Configuration --> Settings`, activate :guilabel:`Digital | ||
| Documents`, and click :guilabel:`Save`. | ||
| Such documents can ensure everything is returned on-time and in its original condition. |
There was a problem hiding this comment.
This line seems oddly placed. What is the document referring to? The Request signature we just sent out? For continuity, I recommend moving this up to the previous line with the previous paragraph
| .. note:: | ||
| This feature also requires the :doc:`Sign <../productivity/sign>` app. If necessary, Odoo | ||
| automatically installs it after activating the :guilabel:`Digital Documents` setting. | ||
| This feature also requires the :doc:`Sign <../productivity/sign>` app. |
There was a problem hiding this comment.
Let's put this as an important note at the very top of the Customer signature section
| To request a customer signature on a rental agreement, select a confirmed rental order and, from the | ||
| :icon:`fa-cog` :guilabel:`(Actions icon)` menu, click :guilabel:`Request Signature` to reveal a | ||
| :guilabel:`Sign Documents` pop-up window. |
There was a problem hiding this comment.
oh this sounds kinda like a repeat of info from the previous paragraph? can we just keep one?
|
|
||
| A separate page is then revealed, showcasing the document to be signed, which is accessible to the | ||
| customer via the customer portal. | ||
| A link to the signature request will appear in the record's Chatter. The document is accessible |
There was a problem hiding this comment.
| A link to the signature request will appear in the record's Chatter. The document is accessible | |
| A link to the signature request will appear in the record's chatter. The document is accessible |
| Odoo guides the customer through the signing process with clear, clickable indicators, and allows | ||
| them to create electronic signatures to quickly complete the form. |
There was a problem hiding this comment.
I feel like we can be more specific here, even if we're just really direct and short with it. Click the signature, then the :guilabel:Preview button .... and link to the Sign doc. I know their doc might already cover it, so we don't need to provide much context or images, but it's better to document the whole workflow from end-to-end, which includes the part that crosses over to another app!
