Skip to content

Conversation

@jero-odoo jero-odoo self-assigned this Oct 30, 2025
@jero-odoo jero-odoo added the 2 label Oct 30, 2025
@robodoo
Copy link
Collaborator

robodoo commented Oct 30, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 30, 2025 13:14
@jero-odoo
Copy link
Contributor Author

@Felicious this is ready for review. Thanks!

@jero-odoo jero-odoo requested a review from Felicious October 30, 2025 13:48
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @jero-odoo ! Thanks for removing the visibility days parts as instructed (:

However, since Visibility Days was removed in version 19 but its use case is now handled through the Horizon Days feature, please recreate the previous Visibility Days examples using Horizon Days instead, so readers still understand how to achieve the same result with the updated functionality!

After you're done writing that, I'd like to share your draft with the inventory PO so she can verify the behavior matches the workflow she designed (:

@jero-odoo jero-odoo force-pushed the 19.0-inventory-visibility-days-jero branch from 72fdd4d to 705cbd0 Compare October 31, 2025 18:28
@jero-odoo jero-odoo requested a review from Felicious October 31, 2025 18:46
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right direction @jero-odoo ! But seems incomplete with some misalignment on our goal with this task -- to clarify:

  • Visibility days ONLY looked ahead when there was a need to fulfill within the forecasted date. How about Horizon days? Can you verify it behave the same way?
    • If so, can we update the images in the examples, as the POs found those helpful

In general, let's try to make sure images are also updated instead of removed unless there's a strong reason to since they're useful to readers. With screenshots also included it gives us both more confidence that we have the feature correctly documented

@jero-odoo jero-odoo force-pushed the 19.0-inventory-visibility-days-jero branch from 705cbd0 to f80f343 Compare November 3, 2025 18:49
@jero-odoo
Copy link
Contributor Author

@Felicious I believe I understand the issue, I was trying to directly replicate the example from visibility days with horizon days when in reality it is not the same. Instead, I tried to show how changing the horizon window impacts manual replenishment/reordering rules. Let me know if this is more what you had in mind. Thanks!

@jero-odoo jero-odoo requested a review from Felicious November 3, 2025 19:09
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @jero-odoo !

I aligned with the product expert and have been proven wrong that horizon days is not a 1:1 replacement of visibility days. I apologize for the confusion and unnecessary back and forth. I will, however, request that you replace the twenty and thirty day screenshots of the UI with a graphic depicting how the timeline is affected by deadlines and horizon dates. I believe it will be helpful for users to envision how horizon days affects deadlines.

Thank you for your patience!

@robodoo delegate+

@jero-odoo jero-odoo force-pushed the 19.0-inventory-visibility-days-jero branch from f80f343 to d744416 Compare November 7, 2025 19:29
@jero-odoo
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants