-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IMP] Payroll: Updating Jordan Payroll Localization #14963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Moah-odoo - this is ready for a review! When you have a moment, I need one piece of info: I am missing the "Dependencies" column for Jordan. Please let me know what needs to be changed for that. I updated the US column with "Jordan" but I am afraid there is more to it than that! Otherwise, we are set! Also, I realized I was working on version 19, NOT 18, so I closed my previous PR that was for 18. Since I was mostly finished with 19 I did not want to go back and revert it, so I will work on 18 AFTER this PR is finalized. Thank you!!! |
1f4043f to
04173d5
Compare
Moah-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes, and we are good to go :)
content/applications/hr/payroll/payroll_localizations/jordan.rst
Outdated
Show resolved
Hide resolved
04173d5 to
27964b1
Compare
|
OK @Moah-odoo - this should be good to go! If you agree, please approve. Thank you! |
Moah-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to Go :)
|
Alright @Felicious - this is ready for you! =) |
|
@robodoo r+ |
closes #14963 Signed-off-by: Felicia Kuan (feku) <[email protected]>
|
@larm-odoo @Felicious staging failed: ci/documentation (view more at https://runbot.odoo.com/runbot/batch/2198368/build/91958354) |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo delegate=larm-odoo
27964b1 to
423338f
Compare
423338f to
2269463
Compare
|
@robodoo r+ |


I was tagged in this task card to update the Jordan Payroll Localization info.
LARM's task card for this PR.