Skip to content

Conversation

@jero-odoo
Copy link
Contributor

Updating to remove references to "Private Address" options, as well as updating images to reflect UI updates
Docs task:https://www.odoo.com/mail/view?model=project.task&res_id=5171761&access_token=f520dcd1-d8ff-4153-a41a-aa06d857d8fd

@jero-odoo jero-odoo self-assigned this Oct 21, 2025
@jero-odoo jero-odoo added the 1 label Oct 21, 2025
@robodoo
Copy link
Collaborator

robodoo commented Oct 21, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 21, 2025 14:18
@jero-odoo
Copy link
Contributor Author

@Felicious sending this straight to you for final/tech. Thanks!

@jero-odoo jero-odoo requested a review from Felicious October 21, 2025 14:22
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting to address Ray’s feedback, @jero-odoo!

It seems this doc is more outdated than we expected and may require broader structural updates to align with the current version. So, I'm bumping this to at least 2 points.

I’ll leave the call to you: if you think a major restructuring is needed and the total changes exceed ~50%, we can increase the PR value to 3 pts.

That said, we should definitely revisit the “Contact form” section, as its structure likely needs adjustment. Also, I couldn’t find the Address Type drop-down in the 19.0 runbot (I might’ve missed it ! feel free to point it out!). If the Address Type can now only be set in the Create Contact form, we’ll need to update the doc accordingly.

Comment on lines 38 to 41
.. tip::
If the :guilabel:`Individual` option is chosen, then the *type of address* can be chosen from a
If the :guilabel:`Person` option is chosen, then the *type of address* can be chosen from a
drop-down menu. Options for this drop-down menu include: :guilabel:`Contact`, :guilabel:`Invoice
Address`, :guilabel:`Delivery Address`, :guilabel:`Other Address`, and :guilabel:`Private
Address`.
Address`, :guilabel:`Delivery Address`, and :guilabel:`Other Address`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I've read the document to the end, I think the only place we should talk about the address type is in the "Create Contact" pop-up and we should just remove this.

What I'd need your help determining: what should the Address in the contact form always be? For example, if we're creating an invoice contact type, what should they put in the Address field of the contact form? Is it different from the one they'd enter on the "Create Contact" pop-up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused by what you are asking here. You cannot select the address type on the MAIN contact form (directly under the contact name). You select it on the "Add contact" tab, which is where you add "alternate" contacts.

@Felicious Felicious added 2 and removed 1 labels Oct 21, 2025
@jero-odoo jero-odoo force-pushed the 19.0-contacts-error-jero branch from 7ec6918 to 5b777db Compare October 23, 2025 16:02
@jero-odoo jero-odoo added 3 and removed 2 labels Oct 23, 2025
@jero-odoo
Copy link
Contributor Author

Hey @Felicious this is ready for another review. It involved some pretty significant changes (more than 50%).
Something to note, the UBO tab is related to the Equity app, and there is no docs on that yet. I included information on how to request the contact to fill out the form for that, and how the tab reflects information from the app, but I did not dig too deep into editing the tab. It is possible to make changes to the holdings on the tab within the contact record, but I do not know if it is necessarily recommended (since it involves stocks and voting shares, I didn't want to overstep), so I kept the information minimal.
Let me know if you have any questions. Thanks!

@jero-odoo jero-odoo requested a review from Felicious October 23, 2025 16:21
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts on updating the doc in its entirety, and looking into the UBO tab, @jero-odoo (:

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants