-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[IMP] Contacts: Address type correction #14958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Felicious sending this straight to you for final/tech. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting to address Ray’s feedback, @jero-odoo!
It seems this doc is more outdated than we expected and may require broader structural updates to align with the current version. So, I'm bumping this to at least 2 points.
I’ll leave the call to you: if you think a major restructuring is needed and the total changes exceed ~50%, we can increase the PR value to 3 pts.
That said, we should definitely revisit the “Contact form” section, as its structure likely needs adjustment. Also, I couldn’t find the Address Type drop-down in the 19.0 runbot (I might’ve missed it ! feel free to point it out!). If the Address Type can now only be set in the Create Contact form, we’ll need to update the doc accordingly.
| .. tip:: | ||
| If the :guilabel:`Individual` option is chosen, then the *type of address* can be chosen from a | ||
| If the :guilabel:`Person` option is chosen, then the *type of address* can be chosen from a | ||
| drop-down menu. Options for this drop-down menu include: :guilabel:`Contact`, :guilabel:`Invoice | ||
| Address`, :guilabel:`Delivery Address`, :guilabel:`Other Address`, and :guilabel:`Private | ||
| Address`. | ||
| Address`, :guilabel:`Delivery Address`, and :guilabel:`Other Address`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I've read the document to the end, I think the only place we should talk about the address type is in the "Create Contact" pop-up and we should just remove this.
What I'd need your help determining: what should the Address in the contact form always be? For example, if we're creating an invoice contact type, what should they put in the Address field of the contact form? Is it different from the one they'd enter on the "Create Contact" pop-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little confused by what you are asking here. You cannot select the address type on the MAIN contact form (directly under the contact name). You select it on the "Add contact" tab, which is where you add "alternate" contacts.
Co-authored-by: Felicia Kuan <[email protected]>
7ec6918 to
5b777db
Compare
|
Hey @Felicious this is ready for another review. It involved some pretty significant changes (more than 50%). |
Felicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your efforts on updating the doc in its entirety, and looking into the UBO tab, @jero-odoo (:
@robodoo r+

Updating to remove references to "Private Address" options, as well as updating images to reflect UI updates
Docs task:https://www.odoo.com/mail/view?model=project.task&res_id=5171761&access_token=f520dcd1-d8ff-4153-a41a-aa06d857d8fd