[IMP] Subscriptions: General style alignment #14851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Felicious
approved these changes
Oct 20, 2025
Contributor
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Looks good to me, @theRealThagomizer !
I just had some minor wording suggestions here and there! After going through the comments, feel free to merge!
@robodoo delegate+
Co-authored-by: Felicia Kuan <[email protected]>
theRealThagomizer
force-pushed
the
18.0-subscriptions-will-removal-thjud
branch
from
317c044 to
1272a14
Compare
Contributor
Author
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 23, 2025
closes #14851 Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates 5 files, making the following changes:
make reviewon subscriptions, automatic_alerts, upselling, reports, and eccomerce.rstThis 18.0 PR can FWP up to master.