Skip to content

Conversation

@theRealThagomizer
Copy link
Contributor

This updates the Billing Period language on the subscriptions page to flow more logically and more accurately describe what the Billing Period checkbox actually does. This update also adds clarity to the "Align to Period Start" example and a note that custom period start dates are not available by default.

This 18.0 PR can FWP up to master.

@robodoo
Copy link
Collaborator

robodoo commented Oct 6, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team October 6, 2025 17:58
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with very minor adjustments, @theRealThagomizer !

Just a quick note for the future: I noticed this and the earlier Align to period start PR each touch a small number of lines in the same section, and the changes are related. I understand that at the time you were still getting familiar with Subscriptions, and the follow-up improvements only became clear after completing the first PR.

That said, I’d like us to handle similar cases in a single PR going forward. In this case, we ended up improving about 24 lines total across two PRs, which came out to 4 points — a bit high for the scope of work. I know your goal wasn’t to get more points, but I do want to ensure the points reflect the scale of the change across the team.

I really appreciate your attention to detail and the effort to make the text clearer! That kind of initiative is valuable! As you get more comfortable with subscriptions, the docs here, and the contribution process, it’ll be easier to bundle related edits into one cohesive update next time. 😊

Edit: forgot to delegate

@robodoo delegate+

@theRealThagomizer theRealThagomizer force-pushed the 18.0-subscriptions-billing-period-update-thjud branch from 7724e92 to 8c85440 Compare October 7, 2025 00:06
@theRealThagomizer theRealThagomizer force-pushed the 18.0-subscriptions-billing-period-update-thjud branch from 8c85440 to 9d680e9 Compare October 7, 2025 00:30
@theRealThagomizer
Copy link
Contributor Author

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Oct 7, 2025

@theRealThagomizer you can't review+.

@Felicious
Copy link
Contributor

@robodoo delegate=theRealThagomizer

@theRealThagomizer
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants