-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] Subscriptions: updated Billing Period language and others #14784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Subscriptions: updated Billing Period language and others #14784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with very minor adjustments, @theRealThagomizer !
Just a quick note for the future: I noticed this and the earlier Align to period start PR each touch a small number of lines in the same section, and the changes are related. I understand that at the time you were still getting familiar with Subscriptions, and the follow-up improvements only became clear after completing the first PR.
That said, I’d like us to handle similar cases in a single PR going forward. In this case, we ended up improving about 24 lines total across two PRs, which came out to 4 points — a bit high for the scope of work. I know your goal wasn’t to get more points, but I do want to ensure the points reflect the scale of the change across the team.
I really appreciate your attention to detail and the effort to make the text clearer! That kind of initiative is valuable! As you get more comfortable with subscriptions, the docs here, and the contribution process, it’ll be easier to bundle related edits into one cohesive update next time. 😊
Edit: forgot to delegate
@robodoo delegate+
7724e92 to
8c85440
Compare
Co-authored-by: Felicia Kuan <[email protected]>
8c85440 to
9d680e9
Compare
|
@robodoo r+ |
|
@theRealThagomizer you can't review+. |
|
@robodoo delegate=theRealThagomizer |
|
@robodoo r+ |
closes #14784 Signed-off-by: Thomas Jude Cavazos (thjud) <[email protected]> Co-authored-by: Felicia Kuan <[email protected]>

This updates the Billing Period language on the subscriptions page to flow more logically and more accurately describe what the Billing Period checkbox actually does. This update also adds clarity to the "Align to Period Start" example and a note that custom period start dates are not available by default.
This 18.0 PR can FWP up to master.