[IMP] website: update cookies bar #14686
Conversation
|
|
|
Hello @auva-odoo, I've asked @stbu-odoo to check this documentation beforehand. I'll let you know once it's done. Many thanks 🌷 |
masp-odoo
force-pushed
the
18.0-website-configuration-cookies-bar-masp
branch
from
38f422e to
2535a4d
Compare
|
Thank you @masp-odoo ! I'll remove myself from the list of reviewer in the meantime and you can add me back when the first review is done 🙂 This helps keep my list of PRs to review a bit more accurate 🙏 |
masp-odoo
force-pushed
the
18.0-website-configuration-cookies-bar-masp
branch
from
2535a4d to
e0f3aeb
Compare
masp-odoo
requested review from
auva-odoo
and removed request for
a team and
stbu-odoo
|
Hi @auva-odoo, it's now ready for your review! Thanks 🌻 |
There was a problem hiding this comment.
Thank you for you work @masp-odoo! I added a few comments and suggestions 🙂 As usual, feel free to reach ou if anything's unclear or needs discussing.
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
| The :ref:`Cookies Policy <cookies-bar/policy>` page (/cookie-policy) is automatically created when | ||
| you enable the cookies bar. |
There was a problem hiding this comment.
I'd remove this: given my comment/suggestion below, the Cookies policy section comes just after this paragraph so the sentence isn't needed IMO
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
content/applications/websites/website/configuration/cookies_bar.rst
Outdated
Show resolved
Hide resolved
masp-odoo
force-pushed
the
18.0-website-configuration-cookies-bar-masp
branch
from
e0f3aeb to
6f4eebe
Compare
masp-odoo
force-pushed
the
18.0-website-configuration-cookies-bar-masp
branch
from
6f4eebe to
ed3b63d
Compare
|
Dear @auva-odoo, I apologize for taking more time, but it was actually quite fast. We can discuss the necessity of explaining how to add cookies; certainly, this page would be more complete with this information. 🗒️ |
|
@robodoo r- |
task-4546111
masp-odoo
force-pushed
the
18.0-website-configuration-cookies-bar-masp
branch
from
ed3b63d to
2071246
Compare
|
Hihihi @auva-odoo merciiiiiiiii 🌷 |
task-4546111 closes #14686 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
task-4546111