Skip to content

Conversation

@Felicious
Copy link
Contributor

Address feedback that experts reported (:

  • Fix inaccuracy that MOs and RFQs are triggered all the time --> they're triggered only when we don't have enough in stock
  • Add warning that cancelling SOs do not automatically cancel linked RFQs and MOs

@robodoo
Copy link
Collaborator

robodoo commented Sep 16, 2025

Pull request status dashboard

@Felicious Felicious requested a review from larm-odoo September 16, 2025 20:49
@Felicious
Copy link
Contributor Author

HI @larm-odoo ! can you help with this quick review? (:

@Felicious Felicious added the 2 label Sep 16, 2025
@C3POdoo C3POdoo requested a review from a team September 16, 2025 20:51
Copy link
Contributor

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious - just a couple of suggestions for clarification (probably because I don't know enough about these apps!) Otherwise, looks great. Feel free to ignore my suggestions as well, they're totally optional.

|RFQ| or |MO| is generated and directly linked to the originating |SO| through a smart button.

This approach offers clear traceability, since each |RFQ| or |MO| is tied back to its demand.
However, it is also rigid. If the linked |RFQ| or |MO| is canceled, the |SO| cannot be fulfilled by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend having the sentence from "However" through the end of the paragraaph is an admonition, since this is super critical info. Maybe a warning? Important?

I'd reword it if it's in a block as well. Something like:
Incomplete or partially canceled MO's and RFQ's cause SO's to be incomplete, and unable to be fulfilled. When a linked |RFQ| or |MO| is canceled, the |SO| cannot be fulfilled, and the order must be cancelled and redone.

I don't know if that is correct/the right way of saying it, but it sounds important enough to have a block of its own.
another replenishment document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the feedback!!

Comment on lines 145 to 146
When a |SO| is cancelled, and it had created an |RFQ| or |MO|, only the related delivery order is
cancelled automatically. A warning appears in the |RFQ| or |MO| chatter noting the cancellation, but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the delivery order is cancelled... as opposed to what else? It sounds like other things are not cancelled. I might mention what stays the same. Maybe it's just me who doesn't fully understand this without extra context, but you can add some more info here.

@Felicious Felicious force-pushed the 17.0-inventory-mto-fixes-feku branch from 3f1615a to 31dbe3e Compare September 17, 2025 20:49
@Felicious Felicious force-pushed the 17.0-inventory-mto-fixes-feku branch from 31dbe3e to 7684a33 Compare September 18, 2025 13:07
@Felicious
Copy link
Contributor Author

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants