-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] inventory: mto feedback #14572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
HI @larm-odoo ! can you help with this quick review? (: |
larm-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Felicious - just a couple of suggestions for clarification (probably because I don't know enough about these apps!) Otherwise, looks great. Feel free to ignore my suggestions as well, they're totally optional.
| |RFQ| or |MO| is generated and directly linked to the originating |SO| through a smart button. | ||
|
|
||
| This approach offers clear traceability, since each |RFQ| or |MO| is tied back to its demand. | ||
| However, it is also rigid. If the linked |RFQ| or |MO| is canceled, the |SO| cannot be fulfilled by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend having the sentence from "However" through the end of the paragraaph is an admonition, since this is super critical info. Maybe a warning? Important?
I'd reword it if it's in a block as well. Something like:
Incomplete or partially canceled MO's and RFQ's cause SO's to be incomplete, and unable to be fulfilled. When a linked |RFQ| or |MO| is canceled, the |SO| cannot be fulfilled, and the order must be cancelled and redone.
I don't know if that is correct/the right way of saying it, but it sounds important enough to have a block of its own.
another replenishment document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty for the feedback!!
| When a |SO| is cancelled, and it had created an |RFQ| or |MO|, only the related delivery order is | ||
| cancelled automatically. A warning appears in the |RFQ| or |MO| chatter noting the cancellation, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the delivery order is cancelled... as opposed to what else? It sounds like other things are not cancelled. I might mention what stays the same. Maybe it's just me who doesn't fully understand this without extra context, but you can add some more info here.
3f1615a to
31dbe3e
Compare
31dbe3e to
7684a33
Compare
|
@robodoo r+ |
closes #14572 Signed-off-by: Felicia Kuan (feku) <[email protected]>

Address feedback that experts reported (: