Skip to content

Conversation

@Julien00859
Copy link
Member

No description provided.

@robodoo
Copy link
Collaborator

robodoo commented Jul 18, 2025

Pull request status dashboard

@Julien00859 Julien00859 force-pushed the master-json2doc-juc branch 2 times, most recently from 078ad01 to 5230acf Compare July 18, 2025 10:53
@Julien00859 Julien00859 marked this pull request as draft July 18, 2025 10:54
@Julien00859 Julien00859 force-pushed the master-json2doc-juc branch 2 times, most recently from 088509f to f87ee68 Compare July 30, 2025 16:33
@Julien00859 Julien00859 marked this pull request as ready for review August 18, 2025 14:19
@C3POdoo C3POdoo requested review from a team August 18, 2025 14:27
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to move the RPC-related content to a new file and reuse the very well-referenced external_api.rst file for the new external API instead. Then, in 19.1, the file about deprecated-now-unsupported content can be removed.

This is also because we don't document when this or that feature was added, deprecated, or removed. The documentation for version X.Y documents which features exist in Odoo X.Y, no more no less.

@Julien00859
Copy link
Member Author

I think it would be better to move the RPC-related content to a new file and reuse the very well-referenced external_api.rst file for the new external API instead. Then, in 19.1, the file about deprecated-now-unsupported content can be removed.

Done

This is also because we don't document when this or that feature was added, deprecated, or removed. The documentation for version X.Y documents which features exist in Odoo X.Y, no more no less.

That we are dropping XML/JSON-RPC is serious enough to mandate the deprecation danger. A common question I've been asked is "is the JSON-2 API available in 18?", hence the "new in 19.0" passage.

Copy link

@Flotchet Flotchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Clear and all! Just some little grammar stuff and a bit of nitpicks and that's basically all for me.
Thanks for the work 💪

@xpl-odoo xpl-odoo removed the request for review from a team August 19, 2025 08:19
@Julien00859 Julien00859 force-pushed the master-json2doc-juc branch 2 times, most recently from e990922 to e51aa38 Compare September 2, 2025 09:33
@rco-odoo rco-odoo force-pushed the master-json2doc-juc branch from 42d0dc5 to 64a6296 Compare September 3, 2025 15:06
Copy link
Member

@rco-odoo rco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me.

@Julien00859 Julien00859 requested a review from Flotchet September 4, 2025 09:08
@jakubsmolka
Copy link

Would it be possible NOT to rely on OEXP and OCA github communication and send this information directly as a newsletter/through account and partner managers to Odoo partners and customers?

It is big and important enough IMHO to be communicated directly to all necessary stakeholders. The fact that Fabien was considering to completely remove the old API for V19 with basically just 2 months in advance was scary enough, but I believe it is good not to underestimate the time it can take various parties to align themselves with this change - and the only reliable source of communication where Odoo can say "we did our best to reliable inform everyone in time" are the ones mentioned above

@Julien00859
Copy link
Member Author

Hello @jakubsmolka

I like your idea of pro-actively reaching with the stakeholders, I'll try to push the idea at work.

@Julien00859
Copy link
Member Author

@jakubsmolka

We met with Antony about this matter. Our communication will only take place during OXP, we won't use other communication channels, emails to stakeholders have been explicitly ruled out.

@jakubsmolka
Copy link

jakubsmolka commented Sep 4, 2025

@jakubsmolka

We met with Antony about this matter. Our communication will only take place during OXP, we won't use other communication channels, emails to stakeholders have been explicitly ruled out.

OK, thasnk for the info and confirmation. I do wonder in a year when Odoo 20 comes out, how many parties will be surprised and how many external platforms with Odoo integrations will "suddenly" stop working for new customers or after upgrades... but if that's a situation you are fine with occuring, I guess there is nothing else we can do. (and I know it will always happen to a degree that someone will be surprised, but it feels like not doing everything reasonably possible to communicate it properly.... is just inviting to make it worse)

@Julien00859
Copy link
Member Author

Hello @odoo/documents-doc-review we are ready

@AntoineVDV
Copy link
Collaborator

@Julien00859 As discussed, we won't have time to review this until after the freeze. You said it only had to be merged for OXP but if you need the odoo/odoo PR to be merged ASAP, I recommend closing the documentation PR to let the other one go through ;)

@rco-odoo
Copy link
Member

rco-odoo commented Sep 8, 2025

Let the odoo/odoo PR go through.

@rco-odoo rco-odoo closed this Sep 8, 2025
@Julien00859 Julien00859 reopened this Sep 9, 2025
@robodoo robodoo closed this Sep 9, 2025
@robodoo
Copy link
Collaborator

robodoo commented Sep 9, 2025

Reopening a PR in a merged batch is not allowed, create a new PR.

@Julien00859
Copy link
Member Author

Reopening now that the community PR is merged

@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Sep 9, 2025

Woops, that's new 😮
image

You can open a new PR, I will check it now.

Or ask runbot if it's really necessary to prevent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants