-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ADD] reference/external_json_api #14091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
078ad01 to
5230acf
Compare
088509f to
f87ee68
Compare
f87ee68 to
c5c1004
Compare
c5c1004 to
ae75316
Compare
ae75316 to
db1e475
Compare
AntoineVDV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to move the RPC-related content to a new file and reuse the very well-referenced external_api.rst file for the new external API instead. Then, in 19.1, the file about deprecated-now-unsupported content can be removed.
This is also because we don't document when this or that feature was added, deprecated, or removed. The documentation for version X.Y documents which features exist in Odoo X.Y, no more no less.
db1e475 to
f09670f
Compare
Done
That we are dropping XML/JSON-RPC is serious enough to mandate the deprecation danger. A common question I've been asked is "is the JSON-2 API available in 18?", hence the "new in 19.0" passage. |
Flotchet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Clear and all! Just some little grammar stuff and a bit of nitpicks and that's basically all for me.
Thanks for the work 💪
f09670f to
b774950
Compare
b774950 to
6bfca17
Compare
e990922 to
e51aa38
Compare
619701d to
42d0dc5
Compare
42d0dc5 to
64a6296
Compare
rco-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me.
|
Would it be possible NOT to rely on OEXP and OCA github communication and send this information directly as a newsletter/through account and partner managers to Odoo partners and customers? It is big and important enough IMHO to be communicated directly to all necessary stakeholders. The fact that Fabien was considering to completely remove the old API for V19 with basically just 2 months in advance was scary enough, but I believe it is good not to underestimate the time it can take various parties to align themselves with this change - and the only reliable source of communication where Odoo can say "we did our best to reliable inform everyone in time" are the ones mentioned above |
|
Hello @jakubsmolka I like your idea of pro-actively reaching with the stakeholders, I'll try to push the idea at work. |
|
We met with Antony about this matter. Our communication will only take place during OXP, we won't use other communication channels, emails to stakeholders have been explicitly ruled out. |
OK, thasnk for the info and confirmation. I do wonder in a year when Odoo 20 comes out, how many parties will be surprised and how many external platforms with Odoo integrations will "suddenly" stop working for new customers or after upgrades... but if that's a situation you are fine with occuring, I guess there is nothing else we can do. (and I know it will always happen to a degree that someone will be surprised, but it feels like not doing everything reasonably possible to communicate it properly.... is just inviting to make it worse) |
|
Hello @odoo/documents-doc-review we are ready |
|
@Julien00859 As discussed, we won't have time to review this until after the freeze. You said it only had to be merged for OXP but if you need the odoo/odoo PR to be merged ASAP, I recommend closing the documentation PR to let the other one go through ;) |
|
Let the odoo/odoo PR go through. |
|
Reopening a PR in a merged batch is not allowed, create a new PR. |
|
Reopening now that the community PR is merged |

No description provided.