[IMP] developer: small rework of assets page (frontend) #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit applies some remarks by Antoine.
AntoineVDV
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Perfect 👌
I was also bugged by the two sections about loading. I had the feeling that they could be organized differently but I wasn't sure if they applied to assets in general (then they should be H2) or if any of them was specific to bundles (then they should be an H3 of "Bundles"). I see that you sorted that out.
@robodoo r+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit applies some remarks by Antoine.