Skip to content

Conversation

StraubCreative
Copy link
Contributor

Overview
Remove confusing screenshots for customers under Finance > Accounting and Invoicing > Fiscal Localizations section. Customers get confused by the screenshots of the country modules, as they think that those modules are the only country-supported modules we have (which makes more issues than not).

Summary of changes

  • Remove country modules screenshots across localizations_list.rst and fiscal_localization_packages.rst
  • Delete /media folder in /applications/finance/accounting/fiscal_localizations/overview which contain fiscal_localization_packages_selection.png and fiscal_localization_packages_modules.png

Outcomes

  • Removed images will hopefully remove confusion for the customer and will be more likely to follow the text directions which encourage them to look through the entire modules list.
  • Small page-speed improvement with lighter page weight.

Requested by: @jubodoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 12, 2021

@StraubCreative StraubCreative force-pushed the 15.0-finance-remove-fiscal-localization-countries-screenshots-zst branch from 18acc28 to 931710b Compare November 15, 2021 18:14
Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commits need to be squashed into a single commit. Then we're good to go :)

@StraubCreative StraubCreative force-pushed the 15.0-finance-remove-fiscal-localization-countries-screenshots-zst branch from 931710b to 0df4d3b Compare November 16, 2021 19:55
@StraubCreative
Copy link
Contributor Author

LGTM but the commits need to be squashed into a single commit. Then we're good to go :)

Squashed in 0df4d3b.

Good to go?

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo robodoo closed this in 0653e3d Nov 17, 2021
@robodoo robodoo temporarily deployed to merge November 17, 2021 11:22 Inactive
@fw-bot fw-bot deleted the 15.0-finance-remove-fiscal-localization-countries-screenshots-zst branch December 1, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants