Skip to content

Conversation

ged-odoo
Copy link
Contributor

@ged-odoo ged-odoo commented Nov 8, 2021

and add entry for effects registry as well

@robodoo
Copy link
Collaborator

robodoo commented Nov 8, 2021

@ged-odoo ged-odoo force-pushed the 15.0-formatters-parsers-ged branch from 791172c to 2a7214c Compare November 8, 2021 14:15
@ged-odoo ged-odoo requested a review from a team November 8, 2021 14:15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too long title line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure effects should be plural

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the name of the registry it's good as it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure parsers should be plural

Copy link
Collaborator

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

and add entry for effects registry as well
@ged-odoo ged-odoo force-pushed the 15.0-formatters-parsers-ged branch from 2a7214c to 39ac539 Compare November 8, 2021 15:57
@ged-odoo
Copy link
Contributor Author

ged-odoo commented Nov 8, 2021

@robodoo r+

@robodoo robodoo closed this in 624131f Nov 8, 2021
@robodoo robodoo temporarily deployed to merge November 8, 2021 16:04 Inactive
@fw-bot fw-bot deleted the 15.0-formatters-parsers-ged branch November 22, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants