-
Notifications
You must be signed in to change notification settings - Fork 116
[IMP] account: improved send status of invoices visibility #4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0-rd-accounting-onboarding-malb
Are you sure you want to change the base?
[IMP] account: improved send status of invoices visibility #4863
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message needs to be improved 👀
| send_status = fields.Selection( | ||
| selection=[ | ||
| ('sent', "Sent"), | ||
| ('sending', "Sending..."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm why ?
| if move.is_move_sent: | ||
| move.send_status = 'sent' | ||
| elif move.is_move_sent: | ||
| move.send_status = 'sending' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ![]()
| for move in self: | ||
| move.is_being_sent = bool(move.sending_data) | ||
|
|
||
| @api.depends('is_being_sent', 'is_move_sent') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is enough 😄 We don't care about the move being sent asynchronously 😄
| @api.depends('is_being_sent', 'is_move_sent') | |
| @api.depends('is_move_sent') |
bcd626e to
fce748e
Compare
When an invoice is sent there is no other way to ee it than in the form view by the button send & print thus I added an optional hide field in the list view that shows the send status and made 2 filters sent and not sent to easily differentiate those invoices task-5231328
fce748e to
473f5d9
Compare
When an invoice is sent there is no other way to ee it than in the form view by the button send & print thus I added an optional hide field in the list view that shows the send status and made 2 filters sent and not sent to easily differentiate those invoices