[IMP] l10n_fr: automatic display delivery date on fr invoices header #4860
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
vicire1
force-pushed
the
18.0-add-deliver-date-fr-invoice-videc
branch
from
e04f46b to
73e8e87
Compare
| # EXTENDS 'account' | ||
| super()._compute_show_delivery_date() | ||
| for move in self: | ||
| if move.country_code == 'FR': |
There was a problem hiding this comment.
Check l10n_fr_is_company_french, maybe you could use that 👀 Tell me why it would be nice to use that 😄
There was a problem hiding this comment.
Yes as there are multiple countrycode for France it is a better idea 😄
| for move in self: | ||
| if move.country_code == 'FR' and move.is_sale_document() and not move.delivery_date: | ||
| move.delivery_date = move.invoice_date or fields.Date.context_today(self) | ||
| return super()._post(soft) |
There was a problem hiding this comment.
Care when doing a super at the end of the function you could have a case where the delivery date is modified after in the exection. So might be better to put it at the beginning of the function right ? 😄
Also when doing an extension always put the Extend comment 😄
|
|
||
| def _post(self, soft=True): | ||
| for move in self: | ||
| if move.country_code == 'FR' and move.is_sale_document() and not move.delivery_date: |
There was a problem hiding this comment.
Cant you use the show_delivery_date here ? 👀
there was a new legislation in France and the delivery date has to appear on the invoices so now it appears automatically in the customer invoice header and write a date on the invoice layout even if none is specified when creating the invoice task-5231327
vicire1
force-pushed
the
18.0-add-deliver-date-fr-invoice-videc
branch
from
73e8e87 to
1cc39b5
Compare
vicire1
changed the title
there was a new legislation in France and the delivery date has to appear on the invoices so now it appears automatically in the customer invoice header and write a date on the invoice layout even if none is specified when creating the invoice
task-5231327