Skip to content

Conversation

@jedel-odoo
Copy link

@jedel-odoo jedel-odoo commented Nov 4, 2025

For the customer invoices, when we want to do a group payment, changing the memo
of this group payment to 'PAY' instead of 'BATCH' to avoid the confusion with batch payments.

task-5231284

@robodoo
Copy link

robodoo commented Nov 4, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message will need to be fixed to follow the guidelines and also small thing to do in the tests 😄

'use_date_range': True,
'company_id': self.id,
'prefix': 'BATCH/%(year)s/',
'prefix': 'PAY/%(year)s/',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good but i think that if runbot was working like a normal pr, you would have a lot of test failing 👀 Take a look at addons/account/tests/test_account_payment_register.py 😄 Run the tests and check the ones that fails and fix them 😄

For the customer invoices, when we want to do a group payment, changing the memo
of this group payment to 'PAY' instead of 'BATCH' to avoid the confusion with batch payments.

task-5231284
@jedel-odoo jedel-odoo force-pushed the 18.0-rd-accounting-onboarding-group-payment-jedel branch from 21f4f1e to 99ebc61 Compare November 5, 2025 12:47
@malb-odoo
Copy link

r++++ nice work !

@malb-odoo malb-odoo closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants