Skip to content

Conversation

@yagho-odoo
Copy link

…n cancelled, list view

@robodoo
Copy link

robodoo commented Nov 3, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message need to be changed to fit the guideline and one small change that could be done 😄

<field name="invoice_date" optional="show" column_invisible="context.get('default_move_type') not in ('out_invoice', 'out_refund', 'out_receipt')" readonly="state != 'draft'" string="Invoice Date" decoration-warning="abnormal_date_warning"/>
<field name="date" optional="hide" string="Accounting Date" readonly="state in ['cancel', 'posted']"/>
<field name="invoice_date_due" widget="remaining_days" optional="show" invisible="payment_state in ('paid', 'in_payment', 'reversed')"/>
<field name="invoice_date_due" widget="remaining_days" optional="show" invisible="payment_state in ('paid', 'in_payment', 'reversed') or status_in_payment == 'cancel'"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using status_in_payment that depends on the state, you can use state directly 😄

@yagho-odoo yagho-odoo force-pushed the 18.0-accountingOnboarding-t2-yagho branch from 37e179c to 622cab3 Compare November 5, 2025 10:22
@yagho-odoo yagho-odoo changed the title [IMP] accounting: invoice due date should not appear if the invoice i… [IMP] account: hid the invoice due date if the invoice in cancelled in list view Nov 5, 2025
@yagho-odoo yagho-odoo changed the title [IMP] account: hid the invoice due date if the invoice in cancelled in list view [IMP] account: hid the invoice due date if the invoice is cancelled in list view Nov 5, 2025
Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message don't follow the guidelines 👀 and care you have a typo in the title ahah

…in list view

for cancelled invoices, the due date was still showing even though it is not relevant anymore as no payment is expected
task id: 5231295
@yagho-odoo yagho-odoo force-pushed the 18.0-accountingOnboarding-t2-yagho branch from 622cab3 to 80918e0 Compare November 5, 2025 16:04
@yagho-odoo yagho-odoo changed the title [IMP] account: hid the invoice due date if the invoice is cancelled in list view [IMP] account: hide the invoice due date if the invoice is cancelled in list view Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants