[IMP] account: due date invisible on canceled invoices #4846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Nov 5, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Commit message could be a bit more elaborate and one small nitpick 😄
| <field name="invoice_date" optional="show" column_invisible="context.get('default_move_type') not in ('out_invoice', 'out_refund', 'out_receipt')" readonly="state != 'draft'" string="Invoice Date" decoration-warning="abnormal_date_warning"/> | ||
| <field name="date" optional="hide" string="Accounting Date" readonly="state in ['cancel', 'posted']"/> | ||
| <field name="invoice_date_due" widget="remaining_days" optional="show" invisible="payment_state in ('paid', 'in_payment', 'reversed')"/> | ||
| <field name="invoice_date_due" widget="remaining_days" optional="show" invisible="( payment_state in ('paid', 'in_payment', 'reversed')) or (state == 'cancel')"/> |
There was a problem hiding this comment.
no need for the parenthesis 👀
Suggested change
| <field name="invoice_date_due" widget="remaining_days" optional="show" invisible="( payment_state in ('paid', 'in_payment', 'reversed')) or (state == 'cancel')"/> | |
| <field name="invoice_date_due" widget="remaining_days" optional="show" invisible="payment_state in ('paid', 'in_payment', 'reversed') or state == 'cancel'"/> |
Wajih-Wanis
force-pushed
the
18.0-rd-accounting-onboarding-due-date-invis-waoun
branch
from
769547a to
17d8537
Compare
malb-odoo
reviewed
Nov 7, 2025
malb-odoo
left a comment
malb-odoo
left a comment
There was a problem hiding this comment.
Squash the commits and also let's add a nice description to the squashed commit 😄 Let's follow the guidelines
invoices that are cancelled still show the due date on the list view which is counterintuitive as a canceled invoice won't be paid so it should not have a due date, thus this change to hide the due date on canceled invoices task: 5231334
Wajih-Wanis
force-pushed
the
18.0-rd-accounting-onboarding-due-date-invis-waoun
branch
from
17d8537 to
9dccff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.