Skip to content

Conversation

wolfy1339
Copy link
Member

Resolves octokit/core.js#667
Resolves octokit/core.js#665
Partly reverts #719


Before the change?

  • Some consumers of this package could not resolve it properly (ex: jest, ts-node, tsx)
  • CJS consumers would be getting errors even though the package is ESM

After the change?

  • Clients should be able to import the module without any errors with the fallback
  • CJS consumers will generate a better error with the new fallback

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Apr 16, 2024
@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

gr2m
gr2m previously approved these changes Apr 16, 2024
@wolfy1339 wolfy1339 merged commit 81720c7 into main Apr 16, 2024
@wolfy1339 wolfy1339 deleted the fix-esm-exports branch April 16, 2024 23:06
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marekdedic
Copy link
Contributor

Hi, sorry, I think there is a typo in there - doesn't work for me (unlike all the other @octokitbot packages). PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in [BUG]: No "exports" main defined in version 6.0.1

3 participants