Fix WebSocket connect requests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes error with WebSocket connect requests
|
Thanks for the PR @jonian! I'll take a look :) |
|
Great! Thanks for the quick reply. I created a small test application where you can reproduce the issue https://github.com/jonian/nuxt-content-test. Run |
|
The test app to reproduce the issue was very helpful, and I was able to confirm that this PR fixes the issue with secure websockets. Thanks again @jonian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @octavore, this fixes errors on WebSocket connect requests by checking if port is 443 in serveConnect. If there is a better way to check if the connect request is related to TLS, please let me know and I will update my PR. Thanks!