Skip to content

Fix performance issue with Structure.is_merge_node #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fix performance issue with Structure.is_merge_node #1938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions compiler/lib/structure.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,20 @@ let is_forward g pc pc' = Hashtbl.find g.block_order pc < Hashtbl.find g.block_o
let is_merge_node' block_order preds pc =
let s = try Hashtbl.find preds pc with Not_found -> Addr.Set.empty in
let o = Hashtbl.find block_order pc in
let n =
Addr.Set.fold (fun pc' n -> if Hashtbl.find block_order pc' < o then n + 1 else n) s 0
in
n > 1
try
ignore
(Addr.Set.fold
(fun pc' found_first ->
if Hashtbl.find block_order pc' < o
then
if found_first
then (* Exit early to avoid quadratic behavior *) raise Exit
else true
else found_first)
s
false);
false
with Exit -> true

let empty_body body =
List.for_all
Expand Down
Loading