Runtime: implement Json output for Wasm #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
hhugo
reviewed
Aug 2, 2024
hhugo
reviewed
Aug 2, 2024
hhugo
reviewed
Aug 2, 2024
hhugo
reviewed
Aug 2, 2024
hhugo
reviewed
Aug 7, 2024
OlivierNicole
force-pushed
the
converge-jsoo-tip-10
branch
from
2df9e99 to
6965ce1
Compare
hhugo
reviewed
Aug 24, 2024
hhugo
requested changes
Aug 25, 2024
Member
hhugo
left a comment
hhugo
left a comment
There was a problem hiding this comment.
I've changed the tests a little and added a request to add an extra comment.
Looks good otherwise.
OlivierNicole
force-pushed
the
converge-jsoo-tip-10
branch
from
e9fef9d to
282ad39
Compare
hhugo
force-pushed
the
converge-jsoo-tip-10
branch
from
282ad39 to
f90904b
Compare
Contributor
Author
|
Thank you for the review! |
OlivierNicole
commented
Aug 26, 2024
|
|
||
| (**/**) | ||
|
|
||
| val output_ : 'a -> string |
Contributor
Author
There was a problem hiding this comment.
Wasn’t added to the mli by mistake?
Member
There was a problem hiding this comment.
I've added this while playing with tests. I could be removed indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).
In Wasm, some additional functions are required to output Json.