Skip to content

Conversation

@OlivierNicole
Copy link
Contributor

This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).

@hhugo
Copy link
Member

hhugo commented Jul 30, 2024

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

@OlivierNicole
Copy link
Contributor Author

Sorry about that. Done

@OlivierNicole OlivierNicole removed their assignment Jul 31, 2024
@OlivierNicole
Copy link
Contributor Author

Oops, unassigned myself by mistake.

@vouillon vouillon force-pushed the converge-jsoo-tip-04 branch from 3d802b5 to ce437b4 Compare August 1, 2024 14:49
@vouillon
Copy link
Member

vouillon commented Aug 1, 2024

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

@hhugo
Copy link
Member

hhugo commented Aug 2, 2024

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though

@hhugo
Copy link
Member

hhugo commented Aug 2, 2024

It's

Can you try to keep the bytecode mode as well ? It is useful to check js vs non-js behavior

We were only building the code, not running it, though...

I'm pretty sure I've run the byte version at the time to check the behavior. I don't remember why I didn't implement a js-vs-bytecode test though

It's possible that I only ran the byte version without argument, (not calling unregister)

@hhugo hhugo merged commit f014914 into ocsigen:master Aug 3, 2024
@OlivierNicole OlivierNicole deleted the converge-jsoo-tip-04 branch August 20, 2024 13:39
@hhugo hhugo added the wasm label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants