Skip to content

fix: add missing return for stat Unix functions #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2023
Merged

fix: add missing return for stat Unix functions #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6266675
Runtime: fix: add back missing return for caml_unix_lstat_64
brandonspark Oct 24, 2023
1c4652f
Runtime: fix caml_unix_stat_64 too
brandonspark Oct 24, 2023
0f314ea
Changes
brandonspark Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Runtime: fix Dom_html.onIE (#1493)
* Runtime: add conversion functions + strict equality for compatibility with Wasm_of_ocaml (#1492)
* Runtime: Dynlink should be able to find symbols in jsoo_runtime #1517
* Runtime: fix Unix.lstat, Unix.LargeFile.lstat (#1519)
* Compiler: fix global flow analysis (#1494)
* Compiler: fix js parser/printer wrt async functions (#1515)

Expand Down
2 changes: 2 additions & 0 deletions runtime/unix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ function caml_unix_stat(name) {
function caml_unix_stat_64(name) {
var r = caml_unix_stat(name);
r[9] = caml_int64_of_int32(r[9]);
return r;
}

//Provides: caml_unix_lstat
Expand All @@ -154,6 +155,7 @@ function caml_unix_lstat(name) {
function caml_unix_lstat_64(name) {
var r = caml_unix_lstat(name);
r[9] = caml_int64_of_int32(r[9]);
return r;
}

//Provides: caml_unix_mkdir
Expand Down