Skip to content

Compiler: refactor Generate.compile_block #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Compiler: refactor Generate.compile_block #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
42671a1
Compiler: add test for loops
hhugo Nov 18, 2022
73cfa8e
Compiler: small refactoring
hhugo Nov 20, 2022
abd05e8
Compiler: more checks
hhugo Nov 21, 2022
5814a3a
Compiler: some doc for generate.ml
hhugo Nov 18, 2022
a2f68d9
Compiler: refactor compile_block
hhugo Nov 21, 2022
85eb7fe
Compiler: generate: split loop logic out
hhugo Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/bin-js_of_ocaml/compile.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,11 @@ let run
List.iter cma.lib_units ~f:(fun cmo ->
let output_file =
match output_file with
| `Stdout, false -> `Name (gen_unit_filename "./" cmo)
| `Name x, false -> `Name (gen_unit_filename (Filename.dirname x) cmo)
| `Stdout, false -> gen_unit_filename "./" cmo
| `Name x, false -> gen_unit_filename (Filename.dirname x) cmo
| `Name x, true
when String.length x > 0 && Char.equal x.[String.length x - 1] '/' ->
`Name (gen_unit_filename x cmo)
gen_unit_filename x cmo
| `Stdout, true | `Name _, true ->
failwith "use [-o dirname/] or remove [--keep-unit-names]"
in
Expand All @@ -293,7 +293,7 @@ let run
in
if times ()
then Format.eprintf " parsing: %a (%s)@." Timer.print t1 cmo.cu_name;
output_partial code output_file)
output_partial code (`Name output_file))
| `Cma cma ->
let t1 = Timer.make () in
let code =
Expand Down
Loading