Compiler: rewrite the js parser using menhir incremental api #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
fyi @let-def |
Contributor
|
Cool! |
TyOverby
reviewed
May 3, 2020
Collaborator
|
Is the goal with this PR to allow for better regexp parsing? |
2 tasks
Member
Author
|
This PR allows us to parse regexp literal correctly and in a much cleaner way. |
TyOverby
reviewed
May 3, 2020
TyOverby
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the js lexer was trying to adjust its production based on the previous token.
The lexer was also populating the fol (first of line) field that was later used by
Js_parser.Lexer.adjust_tokenand the js parser for semicolon automatic insertion.Using the incremental API of menhir (where the control flow is inverted), we can now remove all theses hacks and move all the logic inside
parser_aux.This also has the advantage of being much more friendly with the stack when running in javascript (jsoo toplevel)