Implement mypy annotations (Resolves #549) #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit: see https://github.com/64bitpandas/ocfweb for full commit history
Member
|
Ah, yeah we need to update the version of the django plugin to work with the new semantic analyzer. If you could update that and mypy itself, that would be great! I'll start reviewing this a bit later. |
Member
Author
|
Alright sounds good! I've fixed the first 2 notes. |
emmatyping
reviewed
Nov 5, 2019
Member
emmatyping
left a comment
emmatyping
left a comment
There was a problem hiding this comment.
This is excellent! Thank you so much for working on it. I have a few nits/suggestions here and there, but otherwise I look forward to this being merged :P
emmatyping
reviewed
Nov 5, 2019
emmatyping
approved these changes
Nov 6, 2019
Member
|
Thank you so much for putting in the time on this! It is greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make improper type usages much easier to catch and encourage better self-documentation in the future :)
Some notes:
Typing annotations are very much WIP and I usedAnytoo liberally, especially forrequest: Anysince I was unsure what typerequestis.request: Anyhas been fixed and replaced withrequest: HttpRequestSome of the
Anykeywords are used purposefully, but many can definitely be improved.new_semantic_analyzerhasn't been enabled yet- an internal error occurs (see bottom of comment for stacktrace) and I figured that fixing it would be a whole other unrelated problem.