Fix the exception to catch when threads is not available
#99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply fixes the exception that should be caught when
threadsis not available.When the compiler is configured with
--disable-systhreads, we get:because the exception that is raised when the lookup fails has been changed without updating the handler.
The issue has been reported in #67 in one use case but the failure is a lot more general than that. It came up in particular in mirage/ocaml-solo5#148.
This PR comes with a CI workflow that shows that the command now works and that was used to ensure first that it was failing as described above before the fix: see the log while it last. I’m not sure whether it would be useful as-is.