Reduce minimum version of ocaml #3146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pinned version of the package "river" has a dependency on the package "ocamlnet" which is not compatible with ocaml 5. This fixes an issue where Dune is unable to find a package solution for this project. Signed-off-by: Stephen Sherratt <[email protected]>
Contributor
Author
|
Fixes #3145 |
16 tasks
Collaborator
|
We should be removing the pin on river instead. If necessary, we need to cut a release of river. Working with one specific version of OCaml instead of supporting multiple is better for build stability and for the contributor experience. |
Contributor
Author
|
Can we use this in the short term while we work on removing the river pin. I'm currently unable to build ocaml.org without this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pinned version of the package "river" has a dependency on the package "ocamlnet" which is not compatible with ocaml 5. This fixes an issue where Dune is unable to find a package solution for this project.