Skip to content

Conversation

@CJs0800
Copy link
Collaborator

@CJs0800 CJs0800 commented Jun 5, 2025

Close #611

@erikmd
Copy link
Collaborator

erikmd commented Jun 5, 2025

Thanks @CJs0800

Your PR has 5 commits, but the first two 37f3e52, f383818 are off-topic, can you remove them from your branch?

Hint: you can use some git rebase -i ... command in a terminal, or rely on Magit.

Also, I believe you had proposed me to include a commit that updates the .gitignore ? feel free to push that commit as well.

@CJs0800 CJs0800 force-pushed the task-611_docker-images branch from 2d24810 to 071d41f Compare June 16, 2025 13:43
@erikmd erikmd force-pushed the task-611_docker-images branch from 071d41f to af5b77a Compare September 2, 2025 13:47
Copy link
Collaborator

@erikmd erikmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @CJs0800,
FYI I've just pushed two changes (replace linux/arm54/v8 with linux/arm64/v8 and interactively rebase your branch in two commits); and I'll merge your PR once the CI is green!

@erikmd erikmd merged commit ac3a017 into ocaml-sf:master Sep 2, 2025
12 checks passed
@erikmd erikmd deleted the task-611_docker-images branch September 2, 2025 14:09
@erikmd erikmd self-assigned this Sep 2, 2025
@erikmd erikmd added this to the learn-ocaml 1.1.0 milestone Sep 2, 2025
@erikmd erikmd added the kind: infrastructure CI, build tools, development tools label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: infrastructure CI, build tools, development tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: auto-deploy Docker images of master and tags for arm64 arch as well

2 participants