fix(grading): avoid failing on sampling arrays with unique elements #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tests fail because of an incompatibility with asak 0.4 (was expecting 0.3), there should be an upper bound. This is unrelated to this PR. The solution would be to merge #481 first ; adding the version constraint now would generate conflicts on the other PRs that actually work. |
Collaborator
|
Hi @AltGr,
Indeed, but the missing upper bound also prevents master to build (and to do any release), so I merged #570 Feel free to rebase this PR #568 on master now, and you'll be able to integrate it at the time you see fit. |
Closes ocaml-sf/learn-ocaml-corpus#39 The sampler was attempting to generate N distinct elements by restarting the provided sampler an arbitrary number of times (100). It would fail if the domain is to small: now it might still return duplicates in this case, which is better than failing for our use-cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ocaml-sf/learn-ocaml-corpus#39
The sampler was attempting to generate N distinct elements by restarting the
provided sampler an arbitrary number of times (100). It would fail if the domain
is to small: now it might still return duplicates in this case, which is better
than failing for our use-cases.