Skip to content

fix(ui): Use proper URL fragments ("#tab=…", not "#tab%3D…") #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(ui): Use proper URL fragments ("#tab=…", not "#tab%3D…") #557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/utils/js_utils.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,11 @@ let parse_fragment () =
let set_fragment args =
let pairs = List.map (fun (n, v) -> n ^ "=" ^ v) args in
let fragment = String.concat "&" pairs in
Url.Current.set_fragment fragment
(* TODO: Replace with
{| Url.Current.set_fragment fragment |}
when https://github.com/ocsigen/js_of_ocaml/pull/1497 is shipped
within learn-ocaml's dependencies. *)
Dom_html.window##.location##.hash := Js.bytestring fragment

let local_args = ref []

Expand Down