Hide tokens in partition-view.html #540

Plictox · 2023-04-20T10:38:29Z

Kind: feature

Close Feature: Add a selector to hide tokens from partition-view pages #528

Description

Checklist

Read the CONTRIBUTING.md guide and:
- Use Atomic Commits so each commit gathers a single logical change
- Use Conventional Commits regarding commit messages (needed by our release toolchain)
Add/update tests
Add/update documentation
…

Note to maintainers

Read this wiki page.
Make sure the PR has a milestone.
Assign yourself before merging.
Either do a regular merge:
- for PRs containing several commits following conventional-commits,
- or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
Or do a squash-merge:
- for PRs containing only 1 commit (not shared with a later PR),
- or for PRs containing several commits that need not be kept in the history;
- → Update the commit message header with a conventional-commit type,
- → Add a footer Close #… if a related issue exists.

src/app/learnocaml_partition_view.ml

static/partition-view.html

src/app/learnocaml_partition_view.ml

static/partition-view.html

erikmd

Dear @Plictox, that looks like a good start.
Here is a review of the current version of your PR.

Co-authored-by: Erik Martin-Dorel <[email protected]>

…de_tokens * 'hide_tokens' of github.com:pfitaxel/learn-ocaml: feat: hide PII feature

erikmd

thanks for your commits → here are new review comments!

src/app/learnocaml_partition_view.ml

static/partition-view.html

src/state/learnocaml_data.ml

src/app/learnocaml_partition_view.ml

static/css/learnocaml_common.css

src/app/learnocaml_partition_view.ml

Co-authored-by: Erik Martin-Dorel <[email protected]>

Plictox · 2023-04-27T13:27:57Z

I finished implementing correctly the feature. There is however a last small issue, the option selected by default is not the one I want (nickname-id). It keeps displaying "Hide PII" in the select button after I load the page.
The rest should be fine.

erikmd · 2023-04-27T13:31:40Z

@Plictox OK good! I'll take a look ASAP.

Meanwhile, feel free to start analyzing #527 :)

Now: 1. "List" 2. "Details" 3. "Answer"

erikmd

Dear @Plictox, good news! I fixed all the issues that we were talking about, then improved the CSS and the .ml code a bit further (already applied the suggestions I spotted during my review).

To sum up, the PR is ready, but let's wait that the CI does its checking, and let's merge on tomorrow…

erikmd · 2023-04-30T21:55:04Z

As a heads-up, here is a screenshot of the resulting view:

* Don't prefix URLs starting with `https?://` at `learn-ocaml build` time Related: #535 and static deployment * Move CSS code as a small cleanup Related: #540

Plictox · 2023-05-02T07:38:23Z

dear erik, it looks great ! And thanks for fixing the issues!

* master: (146 commits) chore(docker): Fix org.opencontainers.image.source label ci(docker): Replace `LABEL` Dockerfile commands with `labels:` (GHA) (ocaml-sf#551) fix(i18n): fix escaping issue in i18n fix(ui): update fr translation feat(ui): add some inline documentation to the teacher tab feat(ui): teacher tab: highlight the "apply" button on unsaved changes fix(ui): show different status for open and closed assigned exercises feat(ui): allow partial CSV export feat(ui): allow name input on teacher token creation feat(ui): better string input dialog chore: Add 2 checkboxes in PULL_REQUEST_TEMPLATE.md fix(web-app): Fix `process_html_file` w.r.t. `base_url` refactor(partition-view): Move adhoc CSS code to learnocaml_partition_view.css ci(docker): Fix build-args syntax (docker/build-push-action@v4) ci(docker): Fix GHA input name: s/build_args/build-args/ ci(docker): Use docker/build-push-action@v4 (ocaml-sf#544) ci(macos): Run the `macOS` workflow as well in the weekly CI build feat(partition-view): Add a selector to show (tokens, nicks, or anon IDs) (ocaml-sf#540) feat(web-app): Add feedback button with internationalized tooltip feat(js_utils): Add HTMLElement.title support ... Conflicts: .ci-macosx.sh .github/workflows/static-builds.yml ci/docker-emacs-learn-ocaml-client/.emacs dune-project learn-ocaml-client.opam learn-ocaml.opam learn-ocaml.opam.locked scripts/static-build.sh src/app/learnocaml_common.ml src/app/learnocaml_common.mli src/app/learnocaml_description_main.ml src/app/learnocaml_index_main.ml src/app/learnocaml_teacher_tab.ml src/app/server_caller.ml src/main/dune src/main/learnocaml_client.ml src/main/learnocaml_server_main.ml src/main/linking_flags.sh src/server/learnocaml_server.ml src/state/learnocaml_api.ml src/state/learnocaml_api.mli src/utils/dune static/css/learnocaml_main.css static/index.html translations/fr.po

Louis Tariot added 2 commits April 20, 2023 10:54

feat: dropdown menu

a026374

feat: dynamic implmentation

41886a5

Plictox assigned Plictox and unassigned Plictox Apr 20, 2023

Plictox requested a review from erikmd April 20, 2023 10:39

Louis Tariot added 2 commits April 20, 2023 15:07

feat: dynamic implementation

88dec16

feat: hide tokens

c3f204f

erikmd added the kind: feature New user-facing feature. label Apr 20, 2023

feat: retrieve students data

3b68d80

erikmd reviewed Apr 23, 2023

View reviewed changes

src/app/learnocaml_partition_view.ml Outdated Show resolved Hide resolved

erikmd reviewed Apr 23, 2023

View reviewed changes

static/partition-view.html Outdated Show resolved Hide resolved

erikmd reviewed Apr 23, 2023

View reviewed changes

src/app/learnocaml_partition_view.ml Outdated Show resolved Hide resolved

erikmd reviewed Apr 23, 2023

View reviewed changes

static/partition-view.html Outdated Show resolved Hide resolved

erikmd reviewed Apr 23, 2023

View reviewed changes

Plictox and others added 7 commits April 24, 2023 16:26

feat: hide PII feature

126b963

Co-authored-by: Erik Martin-Dorel <[email protected]>

feat: corrections

d558618

Merge branch 'hide_tokens' of github.com:pfitaxel/learn-ocaml into hi…

24f951d

…de_tokens * 'hide_tokens' of github.com:pfitaxel/learn-ocaml: feat: hide PII feature

feat: new fonction for hide tokens

b480b4b

feat: implementation new algorithm

858b54c

feat: corrections

a1b7fd4

feat: first working implementation

a7a8c90

erikmd mentioned this pull request Apr 26, 2023

Feature: View synced (not graded) version of students' code #527

Closed

Louis Tariot added 2 commits April 26, 2023 16:48

feat: better implementation

8c2e3e5

feat: enhancing html page

c358b34

erikmd requested changes Apr 26, 2023

View reviewed changes

erikmd reviewed Apr 26, 2023

View reviewed changes

src/app/learnocaml_partition_view.ml Outdated Show resolved Hide resolved

src/app/learnocaml_partition_view.ml Outdated Show resolved Hide resolved

Louis Tariot and others added 4 commits April 27, 2023 09:54

feat: changes from review

32ea5e1

feat: useless code deleted

f4fdd8f

feat: changing variable names

c1f2f2f

Co-authored-by: Erik Martin-Dorel <[email protected]>

feat: improved list_of_students_details

1d3abf4

Co-authored-by: Erik Martin-Dorel <[email protected]>

Plictox and others added 4 commits April 27, 2023 10:38

feat: improved students_partition

7d142b2

Co-authored-by: Erik Martin-Dorel <[email protected]>

feat: changing default selection

5c3a045

feat: implementation for the details tab

9f2c2a6

feat: changing a into span

608301f

erikmd self-assigned this Apr 27, 2023

erikmd added this to the learn-ocaml 1.0.0 milestone Apr 27, 2023

erikmd changed the title ~~Hide tokens~~ Hide tokens in partition-view.html Apr 27, 2023

erikmd added 5 commits April 29, 2023 11:09

feat: Add learnocaml_partition_view.css

d8289fd

fix(partition-view): Fix the order of tabs in responsive mode

6b52d83

Now: 1. "List" 2. "Details" 3. "Answer"

refactor(partition-view): Turn the students_list in students_map ASAP

22542b7

fix: Fix <selected> bugs

11d442d

fix: Apply review changes

0eddfea

erikmd approved these changes Apr 30, 2023

View reviewed changes

erikmd merged commit 58b3644 into ocaml-sf:master May 1, 2023

erikmd deleted the hide_tokens branch May 1, 2023 09:37

github-actions bot mentioned this pull request May 1, 2023

chore(master): release 0.15.0 #511

Merged

erikmd mentioned this pull request May 1, 2023

Don't prefix URLs starting with https?:// at learn-ocaml build time #547

Merged

5 tasks

erikmd mentioned this pull request Aug 23, 2023

2 packages from ocaml-sf/learn-ocaml at 0.15.0 ocaml/opam-repository#24305

Merged

erikmd mentioned this pull request Nov 10, 2023

meta-issue: learn-ocaml 0.15.0+ release plan and milestones suggestions for upcoming releases #508

Open

github-actions bot mentioned this pull request Sep 8, 2025

chore(master): release 1.1.0 #600

Open

Hide tokens in partition-view.html #540

Hide tokens in partition-view.html #540

Uh oh!

Conversation

Plictox commented Apr 20, 2023

Description

Checklist

Note to maintainers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikmd left a comment

Choose a reason for hiding this comment

Uh oh!

erikmd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Plictox commented Apr 27, 2023

Uh oh!

erikmd commented Apr 27, 2023

Uh oh!

erikmd left a comment

Choose a reason for hiding this comment

Uh oh!

erikmd commented Apr 30, 2023

Uh oh!

Plictox commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants