Remove Mechanism-2 (#372), Add a 3-fold on-demand Reload button, Fix extra minor bugs #506
Conversation
This fixes "bug 0" of issue ocaml-sf#505.
…#372) This fixes "bugs 1, 2" of issue ocaml-sf#505.
erikmd
changed the title
|
Hi @yurug, as promised I finished working on this PR that fully fixes #505, plus 2 related minor bugs. In dynamic deployment mode, we now get a 3-fold button like this: English
French
Remarks
|
erikmd
force-pushed
the
fix-reload
branch
2 times, most recently
from
6defeb4 to
31c5cd9
Compare
|
@erikmd I have tested the feature and found an issue. When there are no versions on the server, retrieving the latest graded version (or the last synchronized version) does not work: the dialog box is opened but clicking on "OK" does nothing. (The dialog box stays displayed.) The test has been performed on Google Chrome. |
|
@yurug thanks for your review! I've just pushed after our pair-programming rework/test, so feel free to merge (not squash) once the CI is green anew. Thanks 👍 |
|
Sorry @yurug, I've just noticed I had amended the last commit instead of the last-but-one. I'm doing this right now! stay tuned. |
…-sf#372 This button triggers a "Fetch_save" and makes a menu appear, allowing end users to reuse their latest graded code, their latest saved code, or the initial template code. This button only shows up when a non-static backend is detected. Update the French translation as well. This fixes "bug 3" of issue ocaml-sf#505. Close ocaml-sf#493 Close ocaml-sf#505
…#489) This small patch avoids a warning and also saves one HTTP request.
Done → as one can see, my last force-push induces an empty diff |
|
Hi again @yurug!,
this is now the case 🙃👍 |
2 participants
Kind: bugfix
Close Bug: Mechanism-2 of PR #372 does not work #505
Close Feature: Expose more easily last the two versions of a saved exercise #493
Description
Replace "Mechanism 2" (from PR 372) with a more expressive set of reload features, and fixes minor bugs along the way.
Checklist
Note to maintainers