Skip to content

Conversation

@AltGr
Copy link
Collaborator

@AltGr AltGr commented Oct 7, 2021

Closes #314, #337

Also cleanup the head logos (one camel is enough :) )

And increase the timeout before warning when grading, as requested by some teachers (it happened too fast in normal situations and was distracting to students)

@erikmd erikmd added kind: enhancement Enhancement to an existing user-facing feature. kind: fix labels Oct 7, 2021
@erikmd
Copy link
Collaborator

erikmd commented Oct 7, 2021

BTW, a small request (sorry for the nitpick):

Could you reword (e.g. with rebase -i) your three commit messages so that they follow conventional commits?

E.g.

fix(UI): Increase timeout during grading
fix(UI): Cleanup duplicate, inconsistent camel logos
fix(UI): List exercise status even if the status list isn't initialised; Fix #314

Because since we use release-please, this is the way to ensure commits are listed in the automatically-generated CHANGELOG
(we should definitely document this in CONTRIBUTING.md, did not have to time to do it yet)

@erikmd
Copy link
Collaborator

erikmd commented Oct 11, 2021

Thanks @AltGr! but I believe the type prefix has to be lowercase (fix: or fix(UI):, not Fix:)… so could you please redo a small rebase/force-push?

see this commit message for the comprehensive list of types: 4fd56f7

(admittedly, the spec also allows Pascal-case but I'm unsure it would also be accepted by release-please… and given we'll only have one time to test (at merge time), better safe than sorry :)

@erikmd
Copy link
Collaborator

erikmd commented Oct 13, 2021

Friendly ping @AltGr (for the required rebase -i; but I can also do it if need be; feel free to ask if this helps)

AltGr and others added 5 commits October 16, 2021 01:56
* so that "make update-fr-translation" shouldn't raise:

  ```
  File "docs/_unknown_", line 1, characters 0-0:
  Error: File unavailable: docs/odoc.html
  make: *** [Makefile:12: build] Error 1
  ```

* but this fix is probably incomplete.
@erikmd erikmd merged commit 5ebb02d into ocaml-sf:master Oct 16, 2021
@AltGr
Copy link
Collaborator Author

AltGr commented Oct 18, 2021

Ha, sorry and thanks for the rebase, only saw this just now 😬

@erikmd
Copy link
Collaborator

erikmd commented Oct 19, 2021

Hi @AltGr, no worries :-) And thanks a lot for implementing these fixes!

@erikmd erikmd self-assigned this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement Enhancement to an existing user-facing feature. kind: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress bar for students is not displayed on a fresh repository

2 participants