-
Notifications
You must be signed in to change notification settings - Fork 71
A few fixes, in particular for student follow-up on new repos #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BTW, a small request (sorry for the nitpick): Could you reword (e.g. with rebase -i) your three commit messages so that they follow conventional commits? E.g. Because since we use release-please, this is the way to ensure commits are listed in the automatically-generated CHANGELOG |
|
Thanks @AltGr! but I believe the type prefix has to be lowercase ( see this commit message for the comprehensive list of types: 4fd56f7 (admittedly, the spec also allows Pascal-case but I'm unsure it would also be accepted by release-please… and given we'll only have one time to test (at merge time), better safe than sorry :) |
|
Friendly ping @AltGr (for the required |
* so that "make update-fr-translation" shouldn't raise: ``` File "docs/_unknown_", line 1, characters 0-0: Error: File unavailable: docs/odoc.html make: *** [Makefile:12: build] Error 1 ``` * but this fix is probably incomplete.
|
Ha, sorry and thanks for the rebase, only saw this just now 😬 |
|
Hi @AltGr, no worries :-) And thanks a lot for implementing these fixes! |
Closes #314, #337
Also cleanup the head logos (one camel is enough :) )
And increase the timeout before warning when grading, as requested by some teachers (it happened too fast in normal situations and was distracting to students)