Skip to content

Conversation

@EmileRolley
Copy link
Collaborator

Add issue templates for bug reports, feature requests and questions.

@EmileRolley EmileRolley self-assigned this Jun 23, 2021
@EmileRolley EmileRolley requested a review from yurug June 23, 2021 11:52
@EmileRolley EmileRolley added the kind: enhancement Enhancement to an existing user-facing feature. label Jun 23, 2021
Copy link
Collaborator

@yurug yurug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These templates seem fine, at least for the first version. The usage will show if we need refinements.

@EmileRolley EmileRolley requested a review from yurug June 24, 2021 15:36
@maiste
Copy link
Contributor

maiste commented Jul 12, 2021

@EmileRolley, you might need to rewrite your git history before @yurug merge. Maybe only one single commit is needed.

@EmileRolley
Copy link
Collaborator Author

@EmileRolley, you might need to rewrite your git history before @yurug merge. Maybe only one single commit is needed.

I think using the Squash and merge option is good enough no?

Co-authored-by: Yann Régis Gianas <[email protected]>
Co-authored-by: Étienne Marais <[email protected]>
@yurug yurug merged commit e82c23e into ocaml-sf:master Jul 14, 2021
@EmileRolley EmileRolley assigned yurug and unassigned EmileRolley Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement Enhancement to an existing user-facing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants