Update the markdown-to-html transformation so links open a new tab #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…open in a new tab when clicking on a link
erikmd
reviewed
May 12, 2021
erikmd
reviewed
May 12, 2021
erikmd
requested changes
May 12, 2021
Collaborator
erikmd
left a comment
erikmd
left a comment
There was a problem hiding this comment.
Thanks @LouisAyroles !
I left a few remarks/questions in your PR.
erikmd
approved these changes
May 14, 2021
Collaborator
erikmd
left a comment
erikmd
left a comment
There was a problem hiding this comment.
thanks @LouisAyroles, LGTM − let's wait for the CI now − I guess we could merge it this evening.
* Given we rely on (Omd.to_html ~override) * See also issue ocaml-community/omd#239
erikmd
added
kind: enhancement
erikmd
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: update the transformation from markdown to html which allow to open in a new tab when clicking on a link