Make secret field not visible on first connection #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
requested changes
May 1, 2021
Collaborator
There was a problem hiding this comment.
Thanks @YoanwM! your PR works well, I just left two comments to make the code even more idiomatic :)
You can either refactor your commit locally (by doing emacs src/main/learnocaml_main.ml then git commit -a --amend and finally git push -f) ← recommended approach; or use the automatic buttons Commit suggestion in GitHub (also works, but would have the drawback of creating two more commits, instead of amending the single commit you already pushed).
erikmd
added
the
kind: enhancement
erikmd
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make secret field not visible on the first connection when the secret is not set on the server
Close #303