Add a regression test for `learn-ocaml build'

[agrn]

Commit 5a661e4 ("repo: fix repo generation when an exercise has multiple subdirectories", 2020-05-26) fixed the issue #305, but it did not add any regression test to the test suite to ensure that the behaviour of `learn-ocaml build' stayed correct.

This series cleans up a bit runtests.sh, adds such a test, and makes Travis to check `learn-ocaml build' against learn-ocaml-corpus.

This patch series keeps the general behaviour of runtests.sh -- perhaps in the future, it could be changed to have a TAP-compliant output, or allow it to run without docker?

[erikmd]

Thanks @agrn ;

LGTM, one remark though: there are several occurrences of the pattern

for CORPUS in $(find ./corpuses -mindepth 1 -maxdepth 1 -type d) ; do …; done

but this won't work if ever there is a folder that contains a space (I know this is a priori not the case, but better safe than sorry)

so as suggested in https://mywiki.wooledge.org/BashFAQ/024#Workarounds you may want to phrase your loops like this:

while IFS= read -r CORPUS; do …; done < <(find ./corpuses -mindepth 1 -maxdepth 1 -type d)

BTW feel free to write your bash variable names as lowercase: corpus i/o CORPUS, as by convention, lowercase variables are not intended to be exported as environment variables, and won't thereby clash with (uppercase) environment variables :)

[agrn]

Thank you for your feedback @erikmd!

LGTM, one remark though: there are several occurrences of the pattern ``` for CORPUS in $(find ./corpuses -mindepth 1 -maxdepth 1 -type d) ; do …; done ``` but this won't work if ever there is a folder that contains a space (I know this is a priori not the case, but better safe than sorry) so as suggested in https://mywiki.wooledge.org/BashFAQ/024#Workarounds you may want to phrase your loops like this: ``` while IFS= read -r CORPUS; do …; done < <(find ./corpuses -mindepth 1 -maxdepth 1 -type d) ```

Eww, as if I needed to be reminded why I hate shell scripts with a burning passion. :) I am fixing this as I am writing these lines.

[yurug]

Suggested change

	echo "---> Doing $dir:"
	echo "---> Entering $dir:"

[yurug]

This looks great to me.

Did you try to run shellcheck on your script?

[agrn]

Yes, it reports the usual errors with pushd/popd, let, and backslashes in strings. Other than that, there is also the only for loop that I did not convert -- for some reason, when converted to a while loop, it will execute only for the first file found. I am not sure why it behaves like this.

[erikmd]

LGTM.

@agrn

there is also the only for loop that I did not convert

Granted, but fortunately the loop at stake only deal with *.ml files which (by definition) contain no space:

learn-ocaml/tests/runtests.sh

Line 109 in de6191e

for tosend in $(find . -name "*.ml" -type f -printf "%f\n")

So keeping the PR as is is very OK I guess.

[yurug]

Thanks!