repo: fix repo generation when an exercise has multiple subdirectories #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an exercise is copied to the destination directory, its subdirectories (and their parents) are copied concurrently. This is not an issue when there is only one subdirectory to copy, but not when there is multiple subdirectories. In this case, for each subdirectory of the exercise, `mkdir_p' will check if the parent directory exists. As it does not, they will all attempt to create the parent. One of those will succeed, and the rest will fail with EEXIST. This solves this issue by creating the exercise's destination directory before creating subdirectories. This fixes ocaml-sf#305. Signed-off-by: Alban Gruin <[email protected]>
Collaborator
|
Thanks, @agrn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an exercise is copied to the destination directory, its
subdirectories (and their parents) are copied concurrently. This is
not an issue when there is only one subdirectory to copy, but not when
there is multiple subdirectories. In this case, for each subdirectory
of the exercise, `mkdir_p' will check if the parent directory exists.
As it does not, they will all attempt to create the parent. One of
those will succeed, and the rest will fail with EEXIST.
This solves this issue by creating the exercise's destination
directory before creating subdirectories.
This fixes #305.